- Status changed to Needs work
almost 2 years ago 3:54pm 22 February 2023 - ๐บ๐ธUnited States smustgrave
Tried testing #78
Drupal 10.1 with a standard install
Enabled a 2nd language
Checked "Language from a request/session parameter"
Unchecked "Language from the URL (Path prefix or domain)"
Enabled translations for ArticlesCreated an Article with alias /english
Edited the Article by changing language to my 2nd language
Save the page and the URL is node/1
Go back into edit and my alias is gone.
Adding it back
I still can't go to /englishLet me know if I tested wrong.
- ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
I just ran into this problem on a Drupal 9 site as follows:
- Install Drupal in English
- Enable language module
- Add Afrikaans
- For article content type, enable
Show language selector on create and edit pages
- Create article node in English with alias and alias works as expected
- Create article node in Afrikaans with an alias and alias does not work, only node/123
Added the patch from #78 and then resaved my Afrikaans node and now it's showing the page as
/af/node79aliasaf
.This doesn't make sense to me because I have path prefix language negotiation disabled. IMO, if that's disabled, it should just allow the alias as is.
That said, I haven't read all the comments above :)
- Assigned to yash.rode
- ๐ฎ๐ณIndia yash.rode pune
I also got the same results as #87 ๐ Language-specific aliases only work with url-based language negotiation Needs work
- ๐ฎ๐ณIndia yash.rode pune
#88 ๐ Language-specific aliases only work with url-based language negotiation Needs work seems a different problem, if we look at steps to reproduce we want to edit an article and change the language to non-default. In comment #88 ๐ Language-specific aliases only work with url-based language negotiation Needs work we are just creating an article with non default language which is also a bug, but it is not what this issue is talking about.
๐ Aliases are lost when entity language is changed from the edit form Closed: duplicate seems duplicate of this.
I am trying to fix both the Problems in this issue, so we can close the other one. - last update
over 1 year ago Custom Commands Failed - ๐ฎ๐ณIndia yash.rode pune
The first issue from my comment #92 ๐ Language-specific aliases only work with url-based language negotiation Needs work is not a bug it's designed to work like that, see #347265: URL aliases not working for content not in default language โ .
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:24am 14 July 2023 - last update
over 1 year ago 29,814 pass - ๐ฎ๐ณIndia yash.rode pune
This fixes the problem when we try to edit the language of an existing node.
- Status changed to RTBC
over 1 year ago 6:26pm 17 July 2023 - ๐บ๐ธUnited States smustgrave
Verified the issue described in the IS.
Ran the tests in #95 without the fix and it correctly failed
Behat\Mink\Exception\ResponseTextException : The text "aUpF5Ne1CVk1V1UzpXYkXGjVc4bVyVey" was not found anywhere in the text of the current page.
Think this is good for committer review.
- last update
over 1 year ago 29,816 pass - ๐จ๐ญSwitzerland berdir Switzerland
The bug fix fixed seems to be very different to what the issue title and summary seem to be talking about? the closed issue ๐ Aliases are lost when entity language is changed from the edit form Closed: duplicate seems a better match for that?
- ๐ฎ๐ณIndia yash.rode pune
I agree that the title does not match the fix, but we have already closed ๐ Aliases are lost when entity language is changed from the edit form Closed: duplicate , and the issue summary for this is already the same as of the duplicate, so we can just change the title of this issue and continue here?
- last update
over 1 year ago 29,823 pass - last update
over 1 year ago 29,843 pass - last update
over 1 year ago 29,879 pass - last update
over 1 year ago 29,882 pass - last update
over 1 year ago 29,886 pass - last update
over 1 year ago 29,909 pass - last update
over 1 year ago 29,912 pass - last update
over 1 year ago 29,947 pass - last update
over 1 year ago 29,954 pass - last update
over 1 year ago 29,954 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,960 pass - Status changed to Needs work
over 1 year ago 10:40am 15 August 2023 - ๐ณ๐ฟNew Zealand quietone
I am doing triage on the core RTBC queue โ .
Thanks to everyone for working on this tricky issue.
I read the issue summary. There are steps to reproduce and a proposed resolution, which helps reviewers. However, the proposed resolution refers to drupal_loookup_path which is no longer in core. And it appears the resolution is coming from comment #8, which is 10 years old. The remaining task list has 6 items and there is no indication that they have been resolved. And in the User Interface section there seems to be more tasks. It is rather confusing. Therefor, I am tagging for an issue summary update and setting to needs work.
I read through the comments to determine if there is any task not completed and if the remaining tasks were resolved. There is certainly a lot of discussion here of the problem and possible solutions, all of which should have been summarized in the issue summary. But I fail to see an agreement on the solution. Maybe I missed it? And one patch from here moved to another issue and the latest one is not solving the problem as stated in the Issue Summary.
It was good to find an answer to "what is the use case/reason for the language_url to even exist" (#43). Which is "moderators/editors/admins want to be able to moderate ALL CONTENT under a single domain, because separate domains require separate login sessions and Drupal has no OOB support for sharing sessions between multiple domains. User sessions are a problem when language negotiation is done at the domain level." (#47)
I tested this on Drupal 11.x, using the steps in the Issue Summary. I was able to reproduce the problem. I applied the patch and retested. There was no change. I cleared cache and retested. Again no change. That confirms, for me, that patch #95 is solving the problem in #88 which they say is different. Because this was not tested before setting to RTBC I added the tag for manual testing.
And since the patch in #95 is not fixing the problem in the issue summary, that should be moved to a separate issue. Can someone take care of that?
- ๐ฎ๐ณIndia yash.rode pune
Can we go ahead with #71 ๐ Language-specific aliases only work with url-based language negotiation Needs work and make it work for existing content? I tried testing that the results are same as https://www.drupal.org/project/drupal/issues/1125428#comment-14492542 ๐ Language-specific aliases only work with url-based language negotiation Needs work
- ๐ฎ๐ณIndia yash.rode pune
Hi, does #78 ๐ Language-specific aliases only work with url-based language negotiation Needs work work for anyone? I went through the issue again and tried all the available solutions, only thing worked for me was #69 ๐ Language-specific aliases only work with url-based language negotiation Needs work but that approach will only work for new nodes. Can someone try #78 ๐ Language-specific aliases only work with url-based language negotiation Needs work ?