πŸ‡·πŸ‡΄Romania @aludescher

Account created on 22 November 2006, over 17 years ago
#

Recent comments

πŸ‡·πŸ‡΄Romania aludescher

All we need is to support custom heading elements in Drupal\ckeditor5\Plugin\CKEditor5Plugin\Heading. With this patch the following code works:

/**
 * Implements hook_ckeditor5_plugin_info_alter().
 */
function MYMODULE_ckeditor5_plugin_info_alter(array &$plugin_definitions) {
  assert($plugin_definitions['ckeditor5_heading'] instanceof CKEditor5PluginDefinition);
  // Modify 'Format' options.
  $plugin_definition = $plugin_definitions['ckeditor5_heading']->toArray();
  $options =& $plugin_definition['ckeditor5']['config']['heading']['options'];
  $options[] = [
    'model' => 'paragraphSmall',
    'view' => [
      'name' => 'p',
      'classes' => 'text-small',
    ],
    'title' => t('Paragraph small'),
    'class' => 'ck-heading_paragraph_small',
  ];
  $options[] = [
    'model' => 'headingFancy',
    'view' => [
      'name' => 'h2',
      'classes' => 'fancy',
    ],
    'title' => t('Heading 2 (fancy)'),
    'class' => 'ck-heading_heading2_fancy',
  ];
  $plugin_definitions['ckeditor5_heading'] = new CKEditor5PluginDefinition($plugin_definition);
}

The new options now appear and can be enabled in the text format's Enabled Headings section.

πŸ‡·πŸ‡΄Romania aludescher

Updated issue description to better describe Drupal 9 / 10 differences regarding method return types.

πŸ‡·πŸ‡΄Romania aludescher

The 8.x-3.2 version is marked as Drupal 10 compatible:
https://git.drupalcode.org/project/health_check_url/-/blob/8.x-3.2/healt...

It just needs a release.

πŸ‡·πŸ‡΄Romania aludescher

I would also appreciate a drupal 10 release, might even help making it.

πŸ‡·πŸ‡΄Romania aludescher

The sendAws() method tries to create FormattableMarkup messages using the entire $context parameter which sometimes contains keys without a placeholder prefix.
This results in the following error message: Invalid placeholder (%s) with string: "%s".

From \Drupal\Component\Render\FormattableMarkup::placeholderFormat():

Support for keys without a placeholder prefix is deprecated in Drupal 9.1.0 and will be removed in Drupal 10.0.0.

Fix: filter the $context parameter before creating a FormattableMarkup message.

πŸ‡·πŸ‡΄Romania aludescher

aludescher β†’ made their first commit to this issue’s fork.

Production build 0.69.0 2024