Account created on 23 June 2010, almost 14 years ago
#

Merge Requests

Recent comments

πŸ‡¨πŸ‡³China Lugir

Thanks for the feedback, I'll look into it later.

πŸ‡¨πŸ‡³China Lugir

Code committed and released in version 1.8.1. Thanks everybody.

πŸ‡¨πŸ‡³China Lugir

Thanks for your feedback. I will look into this later.

πŸ‡¨πŸ‡³China Lugir

The patch #10 works fine on version 2.x.

πŸ‡¨πŸ‡³China Lugir

Fixed and released 1.8.0-rc3. Please give it a try.

πŸ‡¨πŸ‡³China Lugir

I'll check it later. Can you get any error message from the Network panel of browser or the logging page?

πŸ‡¨πŸ‡³China Lugir

Update description

πŸ‡¨πŸ‡³China Lugir

@K3vin_nl Thanks for the patch. It has been committed and released in Mix 1.6.7

πŸ‡¨πŸ‡³China Lugir

@pierostz Thanks for the feedback. Glad that helped.

πŸ‡¨πŸ‡³China Lugir

Hi, uninstalling and re-enabling the module should fix this.

πŸ‡¨πŸ‡³China Lugir

Resize image and implement code style to commands

πŸ‡¨πŸ‡³China Lugir

Add @todo

πŸ‡¨πŸ‡³China Lugir

Add link to project page.

πŸ‡¨πŸ‡³China Lugir

Hi @skyredwang @GΓ‘bor An admin should act for the good of the community, not only for certain clients. And definitely not only acting when someone pushes. That is wrong. Otherwise we wouldn't have more than 50 moderators but almost no one was active. More than 16,000 suggestions need to be reviewed, but we're making no progress. There have been complaints and disappointed posts about that on the group board for years. Please do what an admin needs to do to improve the situation, many thanks.

πŸ‡¨πŸ‡³China Lugir

@skyredwang Comment again just in case you missed the last message.

πŸ‡¨πŸ‡³China Lugir

Add content.

πŸ‡¨πŸ‡³China Lugir

@skyredwang It's not about how many moderators we have in the group, it's about how many of them actually do the reviewing and translating nowadays. I totally agree with you about the quality control thing. As long as you or some other moderators can take time to review the queue every now and then, that should solve our problems.

There are more than 16,000 suggestions waiting for approval and about 2,000 untranslated strings in the Drupal core. My plan is to review and improve the translations related to the Drupal core first. That will take a period of time. So, instead of me to ping you to review my suggestions, could you please review the link once a week or on another regular basis?

https://localize.drupal.org/translate/languages/zh-hans/translate?author...

πŸ‡¨πŸ‡³China Lugir

Hi @skyredwang. Could you assign me the role of "translation self moderator" or "translation community manager" for now? So that I can improve the translations without another active moderator, or assign new moderators.​ As long as there are some other active moderators, the "translation self moderator" role can be revoked.

πŸ‡¨πŸ‡³China Lugir

Thank you both for your kind responses. I didn't get notifications about the reply and the moderator role, and I couldn't choose and save suggested translations before. Seems like a moderator cannot review his own works. I can review others' suggestions now, but since we lack moderators in that group, how can I contribute my suggestions and get them accepted? Do we have to choose between being a translator or a moderator, or can we be both?

πŸ‡¨πŸ‡³China Lugir

Issue fixed in 1.2.1. Please update to the latest version.

πŸ‡¨πŸ‡³China Lugir

Change weight; Add headings; Add a screenshot.

πŸ‡¨πŸ‡³China Lugir

Any update? How do we push this forward?

πŸ‡¨πŸ‡³China Lugir

Hi @Cottser - After some digging, it seems it is not recommended to set the Twig cache option to FALSE even in a dev environment. So the module stops overriding the cache option for better DX and performance. 

Hope you can restore my earlier updates to this document to help the developers know that we have an easier way to enable twig debugging now. Thanks.

πŸ‡¨πŸ‡³China Lugir

Hi @Cottser - Thanks for the quick review. I understand that $twig_config['cache'] = FALSE; will slow down the site because it will recompile all the templates whether they change or not, but the idea here is to do the same thing as what the Disable caching β†’ document suggested. According to that document, almost everybody will copy/paste the twig.config parameters and finally include the cache: false in their development.services.yml file. Drupal console's Drupal site:mode dev command sets cache: false too. It does have side effects (in some situations), but it makes life easier (especially for those who are new to Drupal).

Anyway, I hope cache: false won't be a blocker here, as in most cases, the Mix module does provide a user-friendly way to help theme developers, rather than letting them edit several files or install Drupal Console (which seems not to support PHP 8 and D10 at this point).

Thank you again for your feedback. I am also considering allowing each parameter in twig.config to be set separately. That should provide better development experiences and greater flexibility.

πŸ‡¨πŸ‡³China Lugir

Hi, I came across this issue while promoting the Mix β†’ module, which provides a similar solution to solve this problem. By enabling/disabling twig debugging, twig auto_reload and related caches with a single checkbox. No need to edit the settings*.php and *services.yml files anymore.

Before this issue gets fixed and added to the core, maybe it's worth you guys taking a peek at the Mix module. Perhaps there would be some useful information or ideas that could be used to improve the core.

It would be great if anyone who is interested in the Mix module could try it out, thanks very much.

The following is a screenshot of the settings form.

β†’

πŸ‡¨πŸ‡³China Lugir

Add the mix module to the option list of enable twig debugging.

πŸ‡¨πŸ‡³China Lugir

Add content about using the Mix module for Twig debugging.

πŸ‡¨πŸ‡³China Lugir

Fixed in 1.1.2. Please give it a try.

πŸ‡¨πŸ‡³China Lugir

Hi @GΓ‘bor, did you get any feedback from them?

πŸ‡¨πŸ‡³China Lugir

Issue confirmed, will work on it. Thx

πŸ‡¨πŸ‡³China Lugir

Thanks for the feedback. Could you try the enable/disable again and see if it's a random one-time thing or it just can't be disabled every time?

πŸ‡¨πŸ‡³China Lugir

A new version 1.1.1-rc1 is released, please update and try it out.

Production build 0.69.0 2024