This patch is needed so the module does not break running PHPUnit's code coverage.
This line specifically public function setUp(): void {
The current code is missing the required void return type.
I was about to make a new issue, but this covers fixing the test where setUp() should have a return of void
setup(): void
Not having the return type breaks running code coverage with PHPUnit.
kamkejj → created an issue. See original summary → .
Maybe I missed something, but this fix has not been merged. Looking at the source code you can see it's not there. This issue was marked as duplicate I don't see another issue for this issue,
kamkejj → created an issue.
Added to 2.x branch to release as the Drupal 10 version.
Created a 4.0.x branch to use for a Drupal 10 version and applied the #4 patch.
Patch to add $this->config->get('recursive_relationships' for
if ($entity->getEntityTypeId() === 'paragraph' && $this->config->get('recursive_relationships')) {
per comment #11 🐛 Recursive loading of relationships causes memory errors on save Active
We're on Drupal 9.5.x and it's an error and the modules requirement is Drupal 9.3 and above per your
core_version_requirement: ^9.3 || ^10 in the module's .info file.
You can close the issue, but the fact is it's broken in 9.5, which is allowed by your version requirement, so it sounds like your 4.0 branch should only be Drupal 10, core_version_requirement: ^10, and not `^9.3 || ^10`.
kamkejj → created an issue.
Andy, made the updates and set the default to 500 from 1000.
Deleting 1000 takes ~20 seconds on Pantheon's dev environment. I don't think that's too long, but if you think the default should be lower I can change it.
I'll about getting the other changes completed.