Can't save Embeddings Settings with Pincone

Looks like the issue is already fixed in the 1.0.x-dev. We just have to publish a new release.

Mybad, Just realised that the issue is fixed in `3411462-cant-save-embeddings` branch.

@kamkejj Can you please raise an MR for the same?

It doesn't seem like the validateConfigurationForm should really do anything other than ensure API key and hostname are collected, which can just be made required, and then this method wouldn't be needed at all.

Make sense.

Let me do the changes.

Just realized that we have the same validateConfigurationForm function in the `Milvus` plugin and that is also restricting the form save.

I tested this. When I put in the API Key and Hostname under Pinecode, an error still throws an error as the API Key and Hostname for Milvus haven't been entered, even though Milvus isn't selected.

@ben.bastow The issue is addressed here: https://www.drupal.org/project/openai/issues/3413412 🐛 Validate function is getting called for all the plugins Fixed

@kunal_singh are you saying that this issue is a dupe of the other?
That the other issue is a solution to this one?
I am just trying to figure out which MR to apply

I have merged 🐛 Validate function is getting called for all the plugins Fixed now, thanks!

For this one will review in the MR

Hi @scott_euser,

I found the old/empty config values were being used by the client during the validation.

I've opened an MR (80) to set the new values on the instance before attempting to validate.
This resolves the issue for me.

This is already implemented for the Milvus plugin.

Thanks

Nice one, thank you for spotting that!

Automatically closed - issue fixed for 2 weeks with no activity.