- Issue created by @kamkejj
- Open on Drupal.org βCore: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @kamkejj opened merge request.
- Status changed to Needs work
over 1 year ago 2:23pm 27 April 2023 - πΊπΈUnited States apmsooner
@kamkejj, a few comments...
- The new field type should maybe be a number field so can be validated through html5 widget? This means min, max, step properties.
- If it's timing out with large number, 1000 probably is still way too high a default number. Maybe something like 50 would be adequate? An entity load of anything more than that seems like it could still be a heavy load.
- Need to add the new field to config/schema/gatsby.schema.yml and config/install/gatsby.settings.yml
- Need to add new field to tests/src/Functional/AdminFormTest
- πΊπΈUnited States kamkejj WI
Deleting 1000 takes ~20 seconds on Pantheon's dev environment. I don't think that's too long, but if you think the default should be lower I can change it.
I'll about getting the other changes completed.
- Open on Drupal.org βCore: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Needs review
over 1 year ago 5:47pm 1 May 2023 - πΊπΈUnited States kamkejj WI
Andy, made the updates and set the default to 500 from 1000.
- Open on Drupal.org βCore: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org βCore: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass -
apmsooner β
committed e177a184 on 2.0.x authored by
kamkejj β
Issue #3356434 by kamkejj: Large number of log entries leads to memory/...
-
apmsooner β
committed e177a184 on 2.0.x authored by
kamkejj β
- Status changed to Fixed
over 1 year ago 4:48pm 3 May 2023 - Status changed to Fixed
over 1 year ago 5:49pm 9 May 2023