🇺🇸United States @Cellar Door

Thanks all for this, merged into 5.x and we'll cut an official 5.0 release later today!

great catch! Merged into 5.x branch

For the scope of this ticket for now we've removed the Jquery Once dependency with this commit: https://git.drupalcode.org/project/lockr/-/commit/b1b0b0e30083153518a70f...

Future updates to remove Jquery entirely will happen on a separate issue as Jquery is removed from Drupal 10 core.

Merged into 5.x

Merged into 5.x

Merged into 5.x

Committed to 5.x

Merged into 5.x

Committed to 4.x and also to 5.x.

Merged in - thanks for the work all!

Reviewed and tested against creating/editing keys and Lockr encryption keys and works as expected. Thanks!

Updated the function to only run on runtime phase (not install or update) so it will show in the site status and also to use the config determined location of the certificate. Should also now work with automated hosts like Pantheon who don't require the user to manage their certificates.

Closing out this task as the 5.x branch has the D10 compatibility and php8 compatibility already applied to it and will soon have an official release on it.

Updated w/ code to catch all generic exceptions instead of relying on underlying libraries throwing LockrAPIExceptions. Should prevent WSOD if there's a guzzle error (missing certs etc.)

Patches for this will need to be done in both the Lockr client library and the module to catch the exception. This issue will be for the exception catch and update for the client will come out in 2.0.1 of the Lockr library.

Cellar Door → made their first commit to this issue’s fork.

I updated the commit slightly to use the $value that was already set to use a translated version of "Unknown" but the realpath was used down below instead of $value. This should look/feel as desired now.

Updated to support Pantheon Certs without expiration needing to show.

Thanks for your work on this! It is a great start.

I think we should use the already in place logic for the cert location (using the stored config w/ default fallbacks) and possibly we can borrow the logic from the expiration warning on the admin page for levels of severity.

Once we account for those I think this can be included in the 5.x release

Boosting for review of the MR and inclusion in 5.x release

Thanks for catching this, as php 8.2 is one of the focuses for the 5.x branch. Makes sense after code review and will go through final testing and inclusion to 5.x

Thanks for this addition! Definitely helps the user have positive feedback no issues were present when saving the admin page.

Good catch! Overview looks good, we'll include it in 5.x release once fully tested and accepted.

Simple fix but looks like it does the job! Let's review and include this into the 5.x release

I've done a quick update which will need testing but shows the status of the cert at all times and only highlights it in error with a warning to renew if it's close to expiration.

Cellar Door → made their first commit to this issue’s fork.

Cellar Door → created an issue.

Cleaned up the branch commit history to include @Anna-D's commit and rebased off the project 2.x branch so the MR can be cleanly merged in.

Cellar Door → made their first commit to this issue’s fork.