- Issue created by @nicrodgers
- @nicrodgers opened merge request.
- Issue was unassigned.
- Status changed to Needs review
11 months ago 7:54am 2 August 2023 - Status changed to RTBC
10 months ago 7:17am 22 August 2023 - 🇮🇳India nitesh624 Ranchi, India
Above Merge Request solve the warning related to hook_requirements on status page
- 🇭🇷Croatia trzalica
Iggy_Lakic → made their first commit to this issue’s fork.
- 🇭🇷Croatia trzalica
This fix seems fine, and I also added similar logic to another place inside module, in `LockrAdminController.php`.
I created a patch for this. - Status changed to Needs review
9 months ago 2:49pm 2 October 2023 - 🇬🇧United Kingdom nicrodgers Monmouthshire, UK
Setting back to NR due to #7.
@Iggy i'm confused why you've made a commit to the fork but then uploaded a patch? I can't see any commits from you in the MR. Do you have more changes to push?
- 🇭🇷Croatia trzalica
@nicrodgers sorry for that. Yes, I've made changes inside the LockrAdminController.php where we have similar situation like in lockr.install.
- @iggy_lakic opened merge request.
- 🇨🇦Canada phjou Vancouver/Paris 🇨🇦 🇪🇺
Merge request is fixing the issue, thanks!
-
Cellar Door →
committed ec417080 on 5.x authored by
Iggy_Lakic →
Issue #3378650: Object of class DateTimeImmutable could not be...
-
Cellar Door →
committed ec417080 on 5.x authored by
Iggy_Lakic →
- Status changed to Fixed
8 months ago 4:46pm 27 October 2023 - 🇺🇸United States Cellar Door
Thanks all for this, merged into 5.x and we'll cut an official 5.0 release later today!
Automatically closed - issue fixed for 2 weeks with no activity.