Thank you for the review.
I corrected the code according your above mentioned points. Except for this one
Attributes for plugin implementations are not supported by Drupal 8; the module cannot declare itself compatible with Drupal 8, which is not able to handle attribute plugins. The \Drupal\Core\Queue\Attribute\QueueWorker class itself is not implemented before Drupal 10.
Because the module is declared compatible with drupal 11.1 or higher, so this is not an issue.
I am also waiting for a drupal 11 compatible release. When can we expect it?
Thank you!
There is already an issue for a drupal 11 compatible release. I am therefore closing this issue. Thanks.
I fixed the phpstan errors
nadja_stu → made their first commit to this issue’s fork.
Looking good!
Is there a reason these changes are not yet released? It seems to be enough to only adjust the version requirement in the info.yml file.
Or am I missing something?
Thank you, I corrected the Hook and the version requirement according your suggestions.
Hi @avpaderno,
Please correct me if i got it wrong.
So you are saying that there is no need to define it in the services.yml file, because it is autowired, correct?
But it is required if I want to provide backwards-compatible hook implementations, isn't it?
Currently I implemented it as described in Backwards-compatible Hook implementation for Drupal versions from 10.1 to 11.0 →
So what excatly would you change?
Should I split it in two branches, so I have two versions one for Drupal 11.0.x and one for Drupal 11.x? Similar to what I saw in the NodeHooks example?
Like you said one with the backwards-compatible version for 11.0.x and one with a correctly implemented autowire service for 11.x?
Sorry for my confussion, but I really want to learn how to do it the right way. Thank you so much!
According to this issue:
https://www.drupal.org/project/drupal/issues/3493453
📌
[meta] Clean up hook classes in core
Active
, there is not yet a proper practice for dependency injection in hook classes. Therefore I checked how they did it in Core. They didn't use any dependency injection there. So I figured I wait until I can do it correct rather than just do it.
What are your thoughts on this?
Hi,
Thank you both for claryifing.
I added a queue worker to my project to send the emails. I also implemented the cron hook as a class (including backwards-compatibility).
Hi @alvarodemendoza,
Thanks for reviewing. I am not sure I understand you correctly. Would you use a queue worker/batch process to load all the user? Or would you use it for sending the mail? Or maybe for both those actions?
Thank you very much
Changing issue priority as described in: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/security-coverage/reviewing/issue-priorities →
joachim namyslo → credited nadja_stu → .
Fix the following phpcs warnings and errors:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,yml multisite_manager_tool/
FILE: \multisite_manager_tool\multisite_manager_tool.module
--------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
10 | ERROR | [x] Missing function doc comment
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
13 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
14 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
15 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
16 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
18 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found
| | 6
19 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
19 | ERROR | [x] Closing brace indented incorrectly; expected 0 spaces, found
| | 1
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
18 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found
| | 6
19 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
19 | ERROR | [x] Closing brace indented incorrectly; expected 0 spaces, found
| | 1
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: \multisite_manager_tool.permissions.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: \multisite_manager_tool\src\SitesHelper.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
116 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
116 | ERROR | [x] Object operator not indented correctly; expected 10 spaces
| | but found 8
117 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8
118 | ERROR | [x] Whitespace found at end of line
119 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
nadja_stu → created an issue.
Thank you for reviewing. I corrected the above mentioned points.
nadja_stu → created an issue. See original summary → .
nadja_stu → created an issue.
the error is still appearing for my site too. I have drupal 11.0.9 installed and mailchimp 3.0.0.
I get this error: TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given in mailchimp_get_lists() (line 176 of modules\contrib\mailchimp\mailchimp.module).
My whole site is not working because of this.
nadja_stu → created an issue.
nadja_stu → created an issue.
I tried patch from #15 ✨ content_moderation_notification_mail_data_alter should allow to disable email sending Needs review and it works for me on drupal 10.3.2. I changed the status to needs Review.
I had the same issue with jquery ui menu and jquery ui autocomplete, this patch from here: https://www.drupal.org/project/jquery_ui_autocomplete/issues/3463117#comment-15695667 🐛 Jquery UI unresolved dependency error Needs review
In combination with this patch for jquery ui menu worked for me: https://www.drupal.org/project/jquery_ui_menu/issues/3463116#comment-15739413 🐛 Jquery UI unresolved dependency error Needs review
I needed to do it like this (see attached patch file) to make it work for me.