When adding a Merge Request the Pipeline throws this error in the test phase:
1) Drupal\Tests\content_moderation_notifications\Functional\Form\CrudFormTest::testNoWorkflows
TypeError: Behat\Mink\Element\TraversableElement::findButton(): Argument #1 ($locator) must be of type string, Drupal\Core\StringTranslation\TranslatableMarkup given, called in /builds/issue/content_moderation_notifications-3470888/web/core/tests/Drupal/Tests/WebAssert.php on line 177
This is caused by the testNoWorkflows tests last line:
public function testNoWorkflows() {
// Remove the workflow.
$workflow = Workflow::load('editorial');
$workflow->delete();
$this->drupalLogin($this->adminUser);
$this->drupalGet('/admin/config/workflow/notifications');
$this->clickLink(t('Add notification'));
$this->assertSession()->pageTextContains(t('No workflows available.'));
$this->assertSession()->linkExists(t('Manage workflows'));
$this->assertSession()->buttonNotExists(t('Create Notification'));
}
Run the above mentioned test.
As quick fix convert to string like this:
$this->assertSession()->buttonNotExists((string)t('Create Notification'));
Thanks for fixing the test!
This should be merged asap so that a working test coverage is ensured again.