πŸ‡¨πŸ‡­Switzerland @martinpe

Account created on 6 October 2008, over 16 years ago
#

Merge Requests

More

Recent comments

πŸ‡¨πŸ‡­Switzerland martinpe

martinpe β†’ changed the visibility of the branch 3516451-assertionerror-commerce-must to hidden.

πŸ‡¨πŸ‡­Switzerland martinpe

martinpe β†’ changed the visibility of the branch 3516451-assertionerror-commerce-must to hidden.

πŸ‡¨πŸ‡­Switzerland martinpe

I justed it and it's better to leave this code in.

Here is why:

  1. I started the project with lando start, followed by lando npm run dev to start the frontend
  2. Then I used ./scripts/local/init-project.sh ddev to start the project with DDEV

and I had some problems such as

Port 80 is busy, using 33000 instead, see https://ddev.com/s/port-conflict
Port 443 is busy, using 33001 instead, see https://ddev.com/s/port-conflict

which changed the launch URL to https://starterkit.ddev.site:33001.

When I tried to access the site, it was not able to spin it up.

I think the main culprit is the traefik container (landoproxyhyperion5000gandalfedition) which needs to be fully stopped in order for DDEV to work. So there are some conflicts between DDEV and Lando containers.

Therefore I would leave that check untouched and maybe think of a different solution.
It's possible to configure DDEV to use different ports but just to run it all in parallel, that has to be researched.

πŸ‡¨πŸ‡­Switzerland martinpe

You are right, that line is not needed.

πŸ‡¨πŸ‡­Switzerland martinpe

Ready for review.

πŸ‡¨πŸ‡­Switzerland martinpe

Adding updated patch which works with Drupal 10.3

Production build 0.71.5 2024