๐Ÿ‡ฎ๐Ÿ‡ณIndia @vishal prasad

Account created on 23 January 2023, almost 2 years ago
#

Merge Requests

More

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@avpaderno Its @ajay-mallah who has made fixes of #13 and committed the changes.

and being the co maintainer of the module, I have equal contribution in this module development so I am commenting here.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@avpaderno I have added the suggested changes as per #13, please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Hii @avpaderno i have reached out to @cmlara on drupal slack for the discussion about the proposed resolution, will find a solution for this soon and update the module.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@cmlara since my implementation is not changing the id of the main form so the form alter hooks from other modules are not ignored. and
This also supports a more comprehensive approach

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@cmlara I thought of overriding the core's user entity form directly, as the hook form alter was getting way lengthy and also to follow the OOPs concept properly i avoided the form alter API.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@apaderno can you please Review it again as its already 19th July.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Hi @arijit-acharya!

Thank you for this feature reqquest, It would be better if we could make the otp length configurable too, using the same Config Form

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

status was set to priority by mistake

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@paraderojether Can we review and merge it on priority?

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@Berdir I have tested the 3377195-9.patch by @penyaskito and it works good to me too,
i think we can create a MR and Merge it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

hello @VladimirAus I Tried to reproduce the error following the process you have mentioned, but i didn't get this error also the form is working fine to me, either we need more info about how to reproduce this error or there may be some issue with any other module in your peoject, causing this issue,

Closing it for now.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Hello @paraderojether I have made the requested changes in the Readme file,
i thought Readme file standards are not the Phpcs concern so i never added this extension for PHPCS check,

well i added this extension too and made the required changes. Can you please review it

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@clarkssquared i have updated the issue summary as per suggestion,
please review

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@abhishek_gupta1 I have Raised the MR fixing the PHPCS issues, can you please review it
MR Link

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

I will be solving this issue so assigning to myself.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Vishal Prasad โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@apaderno I have made some changes for the translatable strings, can you please review it

Thanks regards!

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@rohitsharma401 I have viewed the README file content given by @deepak5423 , it seems alright and the standards have been followed up to the mark according to me,
You can add this README.md file to your project.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@vishal.kadam i made the required changes.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@geoanders i have Raised a MR with the drush commands to export content (by id or by type)
please review it

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Vishal Prasad โ†’ changed the visibility of the branch 3323624-drush-command-by-vishal to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Vishal Prasad โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

@vishal.kadam I have made these changes, please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Hello @vishal.kadam I have made the required changes as per phpcs suggestions, you can now review the module.
Thank you,

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Thank you @praveen rani for identifying the issue, its now fixed for the new release 1.0.3, you can verify it now.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Can you please be little more specific?

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Hello there!

i have Raised the MR for upgraded version of this module that is compatible with D9 and D10.
Please Review and Merge this MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Vishal Prasad โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Vishal Prasad โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Vishal Prasad โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Hi i just made the changes to the fork, and modified the Readme.txt to <h2>Readme.md</h2> .

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

Vishal Prasad โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia vishal prasad

I had the same error
in that case if you have abackup of the configuration then that will be great and importing the configuration using drush cim should solve the error, but if u don't have the backup then just run composer update and that should solve the issue.

Production build 0.71.5 2024