- Issue created by @dww
- Status changed to Needs review
over 1 year ago 9:27pm 1 June 2023 - last update
over 1 year ago 62 pass, 2 fail - ๐บ๐ธUnited States dww
Only change the config in the default view we ship. Don't worry about existing sites -- they can change this themselves (if they haven't already). ;)
The last submitted patch, 2: 3364307-2.patch, failed testing. View results โ
- ๐บ๐ธUnited States dww
Hrm, weird. Locally,
Drupal\Tests\redirect\FunctionalJavascript\RedirectJavascriptTest
from the end of the 8.x-1.x branch (current commit 528b3198) is currently failing against my clean D9.5 test site:Testing Drupal\Tests\redirect\FunctionalJavascript\RedirectJavascriptTest E 1 / 1 (100%) Time: 1.08 minutes, Memory: 8.00 MB There was 1 error: 1) Drupal\Tests\redirect\FunctionalJavascript\RedirectJavascriptTest::testRedirectUI Error: Call to a member function press() on null /.../redirect/tests/src/FunctionalJavascript/RedirectJavascriptTest.php:255 /.../vendor/phpunit/phpunit/src/Framework/TestResult.php:703 ERRORS! Tests: 1, Assertions: 15, Errors: 1.
Seems that the 'Cancel' link in the delete confirmation form is a 404. Re-creating that locally, outside of the test, same effect. It seems that because my site is installed in a subdirectory, something is getting confused and adding the subdirectory twice.
Anyway, I can't imagine how the change to the sort order explains the JS test failure, and I can't reproduce it locally to debug. ๐ข Maybe it's just a random fail here on the test bot?
- last update
over 1 year ago 57 pass, 6 fail - last update
over 1 year ago 62 pass, 2 fail - ๐ฎ๐ณIndia vishal prasad
Vishal Prasad โ made their first commit to this issueโs fork.
- Merge request !62Issue #3364307: Use created DESC for default sort at /admin/config/search/redirect โ (Open) created by vishal prasad
- last update
about 1 year ago 62 pass, 2 fail - last update
about 1 year ago 62 pass, 2 fail - last update
about 1 year ago 62 pass, 2 fail - last update
about 1 year ago 62 pass, 2 fail - last update
about 1 year ago 62 pass, 2 fail - ๐ฆ๐บAustralia pameeela
Just came to create this issue if it didn't already exist :) This drives me nuts!
Surely this change won't break any tests?
- First commit to issue fork.
- Status changed to Needs work
4 months ago 7:56am 10 August 2024 - ๐จ๐ญSwitzerland berdir Switzerland
> Surely this change won't break any tests?
Yes it does.
The test expects the first one in the list to be a specific one, and that's changing.