Reims
Account created on 27 October 2022, over 2 years ago
#

Merge Requests

Recent comments

πŸ‡«πŸ‡·France notFloran Reims

@luke_nuke Any news for a new release with this fix ?

πŸ‡«πŸ‡·France notFloran Reims

I have a similar issue on one of my projects, some users have JS errors related to Drupal.AjaxCommands.prototype.

Applying the change fixed the issue.

πŸ‡«πŸ‡·France notFloran Reims

Any news for a new release with this fix ?

πŸ‡«πŸ‡·France notFloran Reims

Thanks for this quick fix!

πŸ‡«πŸ‡·France notFloran Reims

Hello sarwan_verma,

Thanks for your fix but it's not working, isset don't check the value of $searchFilterPresent but if the property exists or not.
I made a PR with a new fix.

πŸ‡«πŸ‡·France notFloran Reims

Yep I know is not a solution, my comment about that was here to help to debug the issue.

I dig a little more and it seems like it's the call to the "module_handler" service that's causing the problem : $container->get('module_handler')

πŸ‡«πŸ‡·France notFloran Reims

I had the same problem: I had to "enable" the override and then disable it to get everything working properly again

πŸ‡«πŸ‡·France notFloran Reims

With Drupal 10 and the version 1.0.1 of the module the #13 patch is not working.

I have the following error :

TypeError: Drupal\custom_breadcrumbs\BreadcrumbBuilder::__construct(): Argument #10 ($fileUrlGenerator) must be of type ?Drupal\custom_breadcrumbs\FileUrlGeneratorInterface, Drupal\Core\File\FileUrlGenerator given, called in /xxxxx/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\custom_breadcrumbs\BreadcrumbBuilder->__construct() (line 136 of modules/contrib/custom_breadcrumbs/src/BreadcrumbBuilder.php). 

Because the "use" for Drupal\Core\File\FileUrlGenerator is missing.

I have edited the patch to fix the issue.

πŸ‡«πŸ‡·France notFloran Reims

notFloran β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France notFloran Reims

Same issue with the 8.x-3.33 release.

Can you make a new release too ?

Production build 0.71.5 2024