- Issue created by @notFloran
- Merge request !3Issue #3348633: Visible filters checkbox without label β (Merged) created by notFloran
- πΊπΈUnited States MegaKeegMan
Testing MR 3, it appears that the labels are actually the machine names. Using Facets 3, all of the facets are grouped together, so the grouping has a pretty random machine name (generated by the view itself). Anyway, using labels rather than machine names might make more sense here. Definitely an improvement and worth committing though!
- π¬π§United Kingdom aaron.ferris
+1 for this patch, I've also come across this issue. Can confirm patch looks good and works well.
- πͺπΈSpain jlecinaj
I tested locally and the patch is working properly.
+1!
- πͺπΈSpain manuel.adan π
manuel.adan β made their first commit to this issueβs fork.
- Status changed to Needs review
about 1 year ago 6:20pm 14 December 2023 - πͺπΈSpain manuel.adan π
Title was replaced by the filter ID in cases that the empty PHP function evaluates as true, eg. for '0'.
It would be a more complete solution to unconditionally add the filter ID to the labels. By that way, we also cover cases like having different exposed filters with the same title.
-
manuel.adan β
committed 9436f35a on 1.0.x authored by
notFloran β
Issue #3348633 by notFloran, manuel.adan, MegaKeegMan, aaron.ferris,...
-
manuel.adan β
committed 9436f35a on 1.0.x authored by
notFloran β
- Status changed to Fixed
12 months ago 11:44am 28 January 2024 - πͺπΈSpain manuel.adan π
Going ahead with last changes to move forward. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.