Don't exclude ckeditor5 plugin JS from aggregation

Created on 22 January 2024, over 1 year ago

Problem/Motivation

Excluding the plugin from aggregation in combination with calls to Drupal.t() seems to break things under certain circumstances. Core plugins that use Drupal.t() inside their JS are not exlcuded from aggregation, for example internal.drupal.ckeditor5.image.

Steps to reproduce

Unfortunately I can't provide exact steps here, but I think it's good enough to do what core does in this situation, I don't see anything speaking against including the JS in aggregation, I could be missing something though.

Proposed resolution

Include the plugin JS in aggregation by changing the library definition.

📌 Task

Status

Active

Version

2.0

Component

Code

Created by

s_leu

Live updates comments and jobs are added and updated live.

Merge Requests

!16Don't exclude ckeditor5 plugin JS from aggregation
Open
s_leu
updated over 1 year ago

Comments & Activities

Issue created by @s_leu
Merge request !16Draft: Issue #3416230: Don't exclude the ckeditor5 JS plugin from aggregation → (Open) created by s_leu
Comment 9 months ago →
🇫🇷France notFloran Reims
I have a similar issue on one of my projects, some users have JS errors related to Drupal.AjaxCommands.prototype.

Applying the change fixed the issue.
Comment 3 days ago →
🇦🇺Australia jannakha Brisbane!
thanks for your MR!
@s_leu would you like to publish your MR and move the issue to "Needs review"?

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024