Hi! Thanks for this comment.
So, to explain why this composer "repositories" entry is not usually done for Drupal modules, is because Drupal modules are never used/installed as standalone. They need to be installed in the wider context of Drupal installation that already has a 'master' composer.json with relevant entry in "repositories" section.
I hope that makes sense?
BTW: Would you mind adding comments directly here in the forum, instead of using a Google Docs? Google Docs document will probably be deleted on some point and we will loose the history of conversation.
Quick reply to those:
- Empty .js file has been removed. It was just a placeholder in the "dev" stage added in case any .js code is required.
- @TODOs were handled and completed in the latest release
- Added missing dependencies to composer.json
- Other comments are really pertaining to the intricacies of Drupal Coding Standards. For example, DCS requires full namespacing in @var doc blocks.
This change is now merged to dev. Before I mark as fixed, could you confirm that this fixed the original issue on your side as well?
Hi! Thanks for the patch and well spotted. I don't think the issues is due to the SDK version difference. It looks like it was simply a typo. Testing your patch now.
Re. iDeal. Would you mind opening a separate issue and log the details there?
Thanks for reporting! Merged.
Hi! Thanks for that. Would you mind to rebase and reroll? There seem to be conflicts on latest dev.
Here's the initial patch that introduces a feature requested. Comments welcomed.
bdziewierz → created an issue.
Submitted a patch. This adds setters to Event class - that allows other modules to capture the event and modify its properties.
bdziewierz → created an issue.