- Issue created by @v.gelunov
- Status changed to Needs review
11 months ago 10:05am 8 February 2024 - 🇬🇧United Kingdom bdziewierz
Quick reply to those:
- Empty .js file has been removed. It was just a placeholder in the "dev" stage added in case any .js code is required.
- @TODOs were handled and completed in the latest release
- Added missing dependencies to composer.json
- Other comments are really pertaining to the intricacies of Drupal Coding Standards. For example, DCS requires full namespacing in @var doc blocks.
- 🇰🇿Kazakhstan v.gelunov
Okay, everything looks fine, but one quick fix:
https://docs.google.com/document/d/17uheAfTTewluVLfHukHXWzMStyBWaF2pfQqd... - Status changed to Needs work
10 months ago 1:04pm 12 February 2024 - 🇬🇧United Kingdom bdziewierz
Hi! Thanks for this comment.
So, to explain why this composer "repositories" entry is not usually done for Drupal modules, is because Drupal modules are never used/installed as standalone. They need to be installed in the wider context of Drupal installation that already has a 'master' composer.json with relevant entry in "repositories" section.
I hope that makes sense?
BTW: Would you mind adding comments directly here in the forum, instead of using a Google Docs? Google Docs document will probably be deleted on some point and we will loose the history of conversation.