Hello,
Here a small patch to add a hook so that developpers can prevent redirection when needed.
I thought this would be more flexible than just altering the routes.
Tell me if anything wrong.
Regards,
Moving "Convert line breaks into HTML" filter to bottom solves the issue for me (Drupal 10.2.5), but it produces additionnal <p> tags including <a> before and after the media... Tried
#68
🐛
Adding links around embedded media through CKEditor might lead to invalid/complex markup when rendered
Active
but it fails to apply.
<p>
<a href="https://www.google.fr" target="_blank"></a>
</p>
<a href="https://www.google.fr" target="_blank">
<figure class="media media-image media--view-mode--default">
<img loading="lazy" src="..." width="480" height="157" alt="ftyj">
<p></p>
</figure>
</a>
<p>
<a href="https://www.google.fr" target="_blank"></a>
</p>
I don't have much knowledge of FilterAutoP's purpose but I get really weird result if I call it with the following html :
<body>
<a href="https://www.google.fr" target="_blank">
<figure class="media media-image media--view-mode--default">
<img loading="lazy" src="..." width="480" height="157" alt="">
</figure>
</a>
</body>
This is not working... a similar patch has been proposed here 🐛 Deprecated creation of dynamic property in TypedData Needs work but it raises a critical error when editing a content having a workflow (se comment #9 🐛 Deprecated creation of dynamic property in TypedData Needs work )
As a temporary workaround, would it make sense to change web/core/lib/Drupal/Core/TypedData/TypedData.php this way (rather than adding value property which produces bug reported in #9) :
public function getValue() {
if (!isset($this->value)) {
return NULL;
}
return $this->value;
}
It seems to suppress the warning
Patch from @snehal-chibde with just active shadow color updated.
Thank you very much that's really great. One tiny comment though : it's not easy to spot on which color is currently selected because the shadow color is quite light. Do you think you could choose a color that would be a bit darker ?
Thanks again.
Fixed patch name
Thank you Maria for your fix.
Here's a fix for most recent version of the module.
Same, after removing a module (entity_browser), a user role refering to this module was deleted.