🇸🇮Slovenia @gombi

Closing this as the issue has been fixed: https://www.drupal.org/project/autologout/issues/3214958 🐛 Autologout triggered in background tab, no indication in other open tabs Fixed

Hi @dineshkumarbollu, thank you, I completely missed this one!

Going to leave this under Needs review so that someone else can review both our changes :)

Hi @dineshkumarbollu, thanks for taking the time to review.

I see that you ran upgrade_status:analyze for the micro_site module, not the micro_path module. Please check https://www.drupal.org/project/micro_site/issues/3288594 📌 [Micro Site] Automated Drupal 10 compatibility fixes Needs work for the D10 issues relating to micro_site.

Thanks!

The Drupal Rector-provided patch was crashing my Drupal 10 site due to the usage of ModuleHandlerInterface::getImplementations() which was deprecated in Drupal 9.4 and removed in Drupal 10 (see https://www.drupal.org/node/3000490 → ). I've updated the implementation to use ModuleHandlerInterface::invokeAllWith(). Consequently, I've updated the core version requirement to ^9.4 || ^10.

MR !2 should be ready for review.

gombi → made their first commit to this issue’s fork.

I've also encountered this problem during the upgrade to Drupal 10. The merge request 371 should resolve the issue. Moving this to needs review.

gombi → made their first commit to this issue’s fork.

Turns out this was already done and I was checking out an outdated branch. Closing this as outdated. Sorry.

gombi → created an issue.

I've updated the merge request to include the multiple changes done in the 2.0.x branch since it was first opened. I've also added a "php": "^8.0" requirement to the module's composer.json as we're now using Union Types.

The patch applies cleanly for me on Drupal 10, and I was unable to encounter any issues. Moving this back to needs review.

gombi → made their first commit to this issue’s fork.

According to Upgrade Status, MR !2 makes this module compatible with Drupal 10. Moving this to Needs review.

However, I think we will need to resolve https://www.drupal.org/project/aet/issues/3163125 → first, before making a Drupal 10 compatible release.

Hello Bushra,

which version of the module are you using? The patch from MR !1 applies successfully for me on both the dev version and 1.0.0-alpha5 using both cweagans/composer-patches, and manual git apply. When trying to apply the patch on 1.0.0-alpha4, the patch failed on micro_menu.info.yml and LoadTest.php (same as you).

In addition, are you using any other patches for the module? That could mess with applying the patch as well.

gombi → created an issue.

I've added the manual fixes required to make the module work with Drupal 10. I've also updated the test by adding a $defaultTheme, and removed assertions that (seemingly?) rely on related modules not installed with the test. All tests pass locally for me. I've also tested the module with the 2.0.x branch of the bibcite module (D10 compatible) and found no issues. Ready for review.

gombi → made their first commit to this issue’s fork.

I've manually fixed the issues reported by Upgrade Status. It's still reporting "Class Drupal\micro_menu\Form\SiteMenuForm extends @internal class Drupal\menu_ui\MenuForm.", however, I think that can be tackled in another issue. This should now be ready to review.

gombi → made their first commit to this issue’s fork.

I've manually resolved the additional D10 compatibility issues reported by Upgrade Status. Should be ready for review.

gombi → made their first commit to this issue’s fork.

I've fixed additional issues reported by Upgrade Status manually. The tests should pass once https://www.drupal.org/project/micro_site/issues/3288594 📌 [Micro Site] Automated Drupal 10 compatibility fixes Needs work is merged.

I've added a new update hook that installs the jquery_ui and jquery_ui_resizable contrib modules, which are required from D10 onward.

I've fixed additional issues reported by Upgrade Status manually. This should now be ready to review.

gombi → made their first commit to this issue’s fork.

gombi → made their first commit to this issue’s fork.

gombi → made their first commit to this issue’s fork.

I was unable to reproduce the issue described by Nicolas and the patch #6 appears to work for me on Drupal 9.5.9 as well.

I did, however, encounter an issue with it when using "Views: Filter by an entity reference view". When using the patch, the field was ignoring the view and instead always displaying the results in the form of "Title - (ID)". I don't believe this to be the desired effect.

I've modified the patch to only add the entity id inside brackets when editing an existing Entity.

Moving this to needs review, but as I was unable to reproduce the issues described above, the patch might require some additional work.

gombi → made their first commit to this issue’s fork.

Attaching patch.

gombi → created an issue.

Further edits removing the overriding of the name attribute, which messes with the form submission.

Overriding the name attribute will mess with form submission (the element won't be recognized). It's probably best to leave the practice out of Form API #states examples.