Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, over 2 years ago
Updated 1 March 2024, 9 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • @gombi opened merge request.
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    Hi

    I reviewed MR!2 it still as some D10 issues.

    ndor/bin/drush upgrade_status:analyze micro_site
    [notice] Processing /var/www/html/vb9/web/modules/contrib/micro_site.

    ================================================================================
    Micro site, 8.x-1.0-alpha8
    Scanned on Fri, 06/23/2023 - 18:10

    FILE: web/modules/contrib/micro_site/micro_site.module

    STATUS LINE MESSAGE
    --------------------------------------------------------------------------------
    Check manually 96 Call to deprecated function file_create_url(). Deprecated in
    drupal:9.3.0 and is removed from drupal:10.0.0. Use the
    appropriate method on
    \Drupal\Core\File\FileUrlGeneratorInterface instead.
    --------------------------------------------------------------------------------
    Check manually 96 Call to deprecated function file_url_transform_relative().
    Deprecated in drupal:9.3.0 and is removed from
    drupal:10.0.0. Use
    Drupal\Core\File\FileUrlGenerator::transformRelative()
    instead.
    --------------------------------------------------------------------------------
    Check manually 298 Call to deprecated function file_create_url(). Deprecated in
    drupal:9.3.0 and is removed from drupal:10.0.0. Use the
    appropriate method on
    \Drupal\Core\File\FileUrlGeneratorInterface instead.
    --------------------------------------------------------------------------------
    Check manually 298 Call to deprecated function file_url_transform_relative().
    Deprecated in drupal:9.3.0 and is removed from
    drupal:10.0.0. Use
    Drupal\Core\File\FileUrlGenerator::transformRelative()
    instead.
    --------------------------------------------------------------------------------
    Check manually 384 Call to deprecated function file_create_url(). Deprecated in
    drupal:9.3.0 and is removed from drupal:10.0.0. Use the
    appropriate method on
    \Drupal\Core\File\FileUrlGeneratorInterface instead.
    --------------------------------------------------------------------------------
    Check manually 384 Call to deprecated function file_url_transform_relative().
    Deprecated in drupal:9.3.0 and is removed from
    drupal:10.0.0. Use
    Drupal\Core\File\FileUrlGenerator::transformRelative()
    instead.
    --------------------------------------------------------------------------------

    FILE: web/modules/contrib/micro_site/src/Entity/Site.php

  • Comment over 1 year ago →
    🇸🇮Slovenia gombi

    The Drupal Rector-provided patch was crashing my Drupal 10 site due to the usage of ModuleHandlerInterface::getImplementations() which was deprecated in Drupal 9.4 and removed in Drupal 10 (see https://www.drupal.org/node/3000490 → ). I've updated the implementation to use ModuleHandlerInterface::invokeAllWith(). Consequently, I've updated the core version requirement to ^9.4 || ^10.

    MR !2 should be ready for review.

  • Comment over 1 year ago →
    🇸🇮Slovenia gombi

    Hi @dineshkumarbollu, thanks for taking the time to review.

    I see that you ran upgrade_status:analyze for the micro_site module, not the micro_path module. Please check https://www.drupal.org/project/micro_site/issues/3288594 📌 [Micro Site] Automated Drupal 10 compatibility fixes Needs work for the D10 issues relating to micro_site.

    Thanks!

  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    Hi @gombi

    I will review the micro_patch sorry for my bad.

    Thanks

  • Assigned to dineshkumarbollu
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    I reviewed the MR it as one D10 issue, I will work on this.

    vendor/bin/drush upgrade_status:analyze micro_path
    [notice] Processing /var/www/html/vb9/web/modules/contrib/micro_path-3288592.

    ================================================================================
    Micro Path, --
    Scanned on Mon, 06/26/2023 - 12:45

    FILE: web/modules/contrib/micro_path-3288592/src/MicroPathHelper.php

    STATUS LINE MESSAGE
    --------------------------------------------------------------------------------
    Check manually 251 Relying on entity queries to check access by default is
    deprecated in drupal:9.2.0 and an error will be thrown from
    drupal:10.0.0. Call
    \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
    TRUE or FALSE to specify whether access should be checked.
    --------------------------------------------------------------------------------

  • Issue was unassigned.
  • Comment over 1 year ago →
    🇮🇳India dineshkumarbollu

    I reviewed the MR!2 and fixed the D10 error which i mentioned in above comment. Also attaching D10 report.

    Thanks

  • Comment over 1 year ago →
    🇸🇮Slovenia gombi

    Hi @dineshkumarbollu, thank you, I completely missed this one!

    Going to leave this under Needs review so that someone else can review both our changes :)

  • Comment 9 months ago →
    🇫🇷France flocondetoile Lyon
  • Comment 9 months ago →
    System Message
    • gombi → authored 267ad21d on 8.x-1.x 
      Issue #3288592 by gombi, dineshkumarbollu, flocondetoile: Automated...
  • Comment 9 months ago →
    🇫🇷France flocondetoile Lyon
  • Status changed to Fixed 9 months ago
  • Comment 9 months ago →
    🇫🇷France flocondetoile Lyon

    Thanks everyone

  • Comment 9 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024