🇦🇺Australia @Seth Hilder

Account created on 25 September 2020, over 4 years ago
#

Recent comments

🇦🇺Australia Seth Hilder

This patch is an updated version of #16 that also fixed an issue where e.value was undefined when the #states rules are no longer being met, and you are trying to make things enabled. This undefined-ness was leading to different behavior between toggleClass() and prop(), which was preventing the disabled prop not being set when it should have been, even though the form-disabled class was being set.

This very much feels like fixing the symptom and not the cause, but the cause is seemingly buried in the verifyConstraints/checkConstraints code which I unfortunately don't have time to dig into.

🇦🇺Australia Seth Hilder

Hi @doxigo,

Thanks a heap for getting back to me on this so quickly.

I pulled in 5.0.10 and there's still a bit of a regression due to missing "card-header" and "card-body" classes. I've attached some screenshots for reference.

5_0_3.png is how our fieldset looked on Radix 5.0.3
5_0_8.png is how it looked on Radix 5.0.8 after the changes in 5.0.4
5_0_10.png is how it looks with the most recent changes
5_0_10_recreated.png is the classes I needed to add through dev-tools to recreate the exact look of 5.0.3

Let me know if you have any questions or need any more info.

Production build 0.71.5 2024