Stripe sometimes causes commerce_payment to error although it accepts payment

Created on 1 May 2020, over 4 years ago
Updated 30 June 2024, 5 months ago

If Stripe returns an error message such as that described at https://www.drupal.org/project/commerce_stripe/issues/3114861 β†’

we are seeing a watchdog message:

Drupal\commerce_payment\Exception\InvalidRequestException: Invalid parameters were supplied to Stripe's API. in Drupal\commerce_stripe\ErrorHelper::handleException() (line 45 of /var/www/html/subscribe/web/modules/contrib/commerce_stripe/src/ErrorHelper.php).

When such a watchdog message is seen, the order remains with status 'draft'. However, we have seen three cases where Stripe errored, and the above watchdog message was seen, but Stripe accepted payment. I do not know why, and see no indication in watchdog that the order was retried. Sorry, I know this is a half-baked bug report. Perhaps someone who knows the software better will nevertheless be able to see what is going wrong.

Steps to reproduce:
* Add a product to the cart
* Proceed through checkout to the Order Review page
* In a second tab, add a second product to the cart
* In the first tab, click "Pay and Complete Purchase"
* You will be redirected back to the Order Information page, which will show the two products in the cart; however, at the same time, the payment will complete successfully in Stripe.
* Proceed from Order Information to Review page
* On Review page, click "Pay and Complete Purchase"
* Drupal will show the message "A processing error has occurred" (because Stripe has already completed the payment and now we are requesting to complete it again)
* The page will complete loading and Drupal will successfully complete the order.
* Ultimately there will be nothing wrong with the order, but the error message may scare users.

πŸ› Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom John_B London (UK), Worthing (UK), Innsbruck (Tirol)

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024