Undocumented, breaking changes to fieldset

Created on 18 July 2023, over 1 year ago
Updated 17 August 2023, over 1 year ago

Problem/Motivation

Radix 5.0.4 (specifically, 5bd83528 and 3fe440f6) made some pretty big, breaking changes to the markup and classes on fieldsets, a fairly common html element.

The changes removed the card, card-header, and card-body body classes and wrappers, which provide nice, sensible style by default from bootstrap.

These changes were not mentioned in any change logs or release notes that I could find to warn users, and have no issue or MR associated with them that provides justification for these changes.

Proposed resolution

Is it expected that people using radix install it once, build their sub-theme, and then never update radix again?

This issue has only raised it's head thanks to a drupal 10 upgrade, but has now sparked concern that other undocumented changes might slip through testing unnoticed.

🐛 Bug report
Status

Closed: won't fix

Version

5.0

Component

Code

Created by

🇦🇺Australia Seth Hilder

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Seth Hilder
  • Hey Seth, thanks for bringing this up, I'll have to check this out but if it's a breaking change, the expected behavior is to release a new bumped version so this wouldn't happen, if that's the case I must've made a mistake

    I'll check it out soon and see if it's reversable

  • Status changed to Fixed over 1 year ago
  • Seth, this should be fixed on the latest dev, sorry for the breaking change, it was due to the class "card" missing, added it back

  • Status changed to Active over 1 year ago
  • 🇦🇺Australia Seth Hilder

    Hi @doxigo,

    Thanks a heap for getting back to me on this so quickly.

    I pulled in 5.0.10 and there's still a bit of a regression due to missing "card-header" and "card-body" classes. I've attached some screenshots for reference.

    5_0_3.png is how our fieldset looked on Radix 5.0.3
    5_0_8.png is how it looked on Radix 5.0.8 after the changes in 5.0.4
    5_0_10.png is how it looks with the most recent changes
    5_0_10_recreated.png is the classes I needed to add through dev-tools to recreate the exact look of 5.0.3

    Let me know if you have any questions or need any more info.

  • 🇦🇺Australia Tylermc

    I've created a patch that adds the card-header div around the Fieldset legend and the card-body to the Fieldset wrapper div as they were in previous versions (4.12) while leaving the new features of the Fieldset that was added in later versions.

  • Status changed to Closed: won't fix over 1 year ago
  • Even though this might look better, we can't assume all fieldsets should be a card, this can be adjusted within the subtheme

    I think its best to keep things separated, sorry for the breaking change but not gonna merge this

Production build 0.71.5 2024