Uploaded all JPEG to the appropriate Social Media Card field.
First draft is ready for review.
Hi, I'm a new contributor working on updating my pet project to Drupal 11. I've tested Token 8.x-1.x-dev, which is already Drupal 11 compatible after 📌 Drupal 11 compatibility Fixed , on Drupal 10.3 and Drupal 11.0.0-rc1 (together with the dev version of Pathauto), and it works well for both versions.
I ran a final check with Upgrade Status (4.3.4) on Drupal 10.3, and it still shows some deprecation warnings. I checked, and most of them were introduced in 10.3, but since they will all be removed in Drupal 12, it is not a problem for Drupal 11. However, I also see two older unresolved issues in the test files. Although there are confirmations in #3445829 that these do not cause problems, it would still be nice to clean them up to avoid checking them again later, unless I missed something.
web/modules/contrib/token/tests/src/Kernel/EntityTest.php 53 You should use assertFalse() instead of assertSame() when expecting "false"
web/modules/contrib/token/tests/src/Kernel/EntityTest.php 58 You should use assertFalse() instead of assertSame() when expecting "false"I spent quite some time checking all this, and as I'm learning to contribute, I decided to describe it here.
Hi, as a new Drupal contributor I fixed the bug by adding an extra check in the access() method. Now it doesn't show duplicate results when using the widget and the global override at the same time.
melnychukmy → made their first commit to this issue’s fork.
melnychukmy → made their first commit to this issue’s fork.
As new drupal contributor I have tested this module on a Drupal 11.0.0-beta1 using the mglaman/composer-drupal-lenient plugin for installation. Works well with 'Enable globally' flag activated and with 'Autocomplete ID' widget even if 'Enable globally' deactivated. Upgrade status doesn't show any problems.
To not forget about backward compatibility I pushed commit similar to automated change by project update bot in
📌
Automated Drupal 11 compatibility fixes for pathauto
Fixed
Also used trait for logger service.
melnychukmy → made their first commit to this issue’s fork.
I updated deprecated class usage. Not sure how to confirm that it works. I didn't run Behat test locally but can give it a try. Now I'm waiting for CI result. Unfortunately I noticed that CI fails on latest 8.x-2.x branch.
melnychukmy → made their first commit to this issue’s fork.