- Issue created by @berdir
- Merge request !75Add book dev dependency, fix UrlTest, D11 compatibility → (Merged) created by berdir
- Status changed to Needs review
7 months ago 8:12pm 7 May 2024 - First commit to issue fork.
- 🇮🇳India vishalkhode
Ran all PHPUnit tests on Drupal 11 and confirm all tests are passing:
- First commit to issue fork.
- Status changed to RTBC
6 months ago 9:31am 15 May 2024 - 🇮🇳India ankitv18
@Berdir can we merge MR!75? CI is passing now and we can file a separate issues for deprecations in phpunit for D11 and other phpcs and phpstan issues.
- Status changed to Needs review
6 months ago 5:38am 17 May 2024 - 🇨ðŸ‡Switzerland berdir Switzerland
D11 tests are not passing yet.
The previous major was there on purpose, see #3447089: Disable previous major testing with D9 so that modules can prepare for D11.0 → but it looks like it isn't going to happen like I'd prefer so, so maybe I'll leave it out here for now.
-
Berdir →
committed 381ba02f on 8.x-1.x
Issue #3445829 by Berdir, ankitv18, deepakkm: Drupal 11 compatibility
-
Berdir →
committed 381ba02f on 8.x-1.x
- Status changed to Fixed
6 months ago 9:03am 18 May 2024 - 🇨ðŸ‡Switzerland berdir Switzerland
Added the disabled deprecations variable until #3400979: Is SYMFONY_DEPRECATIONS_HELPER: weak correct for contrib deprecation testing needs? → is resolved as a temporary workaround. Merging this.
@vishalkhode: Please do not include screenshots of executed tests (just like you should include screenshots of applying patches), that's considered trying to game the credits system and a waste of disk space on drupal.org
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇮🇳India vishalkhode
@berdir: I understand your point. To clarify, If I had simply moved the ticket forward, it could have raised questions about how it was verified given that the Drupal CI was not working, so I've added comment with screenshots, The screenshot/comment was not intended to gain credit but to confirm that Drupal 11 compatibility changes verified in local by running PHPUnit tests. This was necessary as the Drupal CI was not functioning correctly and was throwing some errors. See this: https://git.drupalcode.org/issue/token-3445829/-/jobs/1591554.
@vishalkhode: Please do not include screenshots of executed tests (just like you should include screenshots of applying patches), that's considered trying to game the credits system and a waste of disk space on drupal.org