Account created on 2 July 2018, over 6 years ago
#

Merge Requests

Recent comments

πŸ‡«πŸ‡·France yfiervil

Try to clear your cache. I have to add a context cache.

πŸ‡«πŸ‡·France yfiervil

Hello,

This message is only display when the public key of the VAPID configuration is not set.
However, it is possible that cache management is missing on that part, could you try to clear your Drupal cache ?

πŸ‡«πŸ‡·France yfiervil

Hello,

have you configure your VAPID authentication Key on the page /admin/config/services/web-push/VAPID ?

You must have some data on this interface :

πŸ‡«πŸ‡·France yfiervil

I have the same issue.
The patch fix the problem.

πŸ‡«πŸ‡·France yfiervil

@Sander Edwards van Muijen do you need more informations ?

πŸ‡«πŸ‡·France yfiervil

On this page : /admin/people/permissions, you have to choose which users have the right the use the REST API. This is usefull when you only want to allow Authenticated user to use the feature.

πŸ‡«πŸ‡·France yfiervil

Thanks for the suggestion.

I have adjust a little your patch. I didn't test it for the moment.

πŸ‡«πŸ‡·France yfiervil

yfiervil β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France yfiervil

One solution is to manage this directly where the DOM is updated.
For exemple on Vue, you can just force the bind with :

onMounted(() => {
  Drupal.ajax.bindAjaxLinks()
})

Did the core really need to manage this case ?

πŸ‡«πŸ‡·France yfiervil

It's the https://github.com/heiseonline/shariff who is in charge to add the icon on the service : https://github.com/heiseonline/shariff/blob/193cd834dedad741aeb265859516...

The class fa-twitter has to be replace by fa-x-twitter : https://fontawesome.com/icons/x-twitter?f=brands&s=solid

The request must be on the https://github.com/heiseonline/shariff and the update the readme of this module to use the right version of the library.

πŸ‡«πŸ‡·France yfiervil

It's not possible to integrate a repository in a non root composer.json : https://getcomposer.org/doc/faqs/why-cant-composer-load-repositories-recursively.md

A similar request exist on TacJS : https://www.drupal.org/project/tacjs/issues/3083861 β†’
The solution was to integrate the lib in the module without composer.

Despite this, we can update the documentation and add a composer.json with an exemple of repository to add it to the root composer.json like this:

{
    "name": "drupal/tarte_au_citron",
    "description": "Manage features which use cookies (ads, social networks, videos, other contrib modules who print data in your pages)",
    "type": "drupal-module",
    "license": "GPL-2.0-or-later",
    "homepage": "https://www.drupal.org/project/tarte_au_citron",
    "support": {
        "issues": "https://www.drupal.org/project/issues/tarte_au_citron",
        "documentation": "https://git.drupalcode.org/project/tarte_au_citron",
        "source": "https://git.drupalcode.org/project/tarte_au_citron"
    },
    "repositories": {
        "tarteaucitron": {
            "type": "package",
            "package": {
                "name": "amauric/tarteaucitron",
                "version": "1.11.0",
                "type": "drupal-library",
                "dist": {
                    "url": "https://github.com/AmauriC/tarteaucitron.js/archive/refs/tags/v1.11.0.zip",
                    "type": "zip"
                },
                "require": {
                    "composer/installers": "^1.9"
                }
            }
        }
    },
    "require": {
        "amauric/tarteaucitron": "^1.11"
    }
}

In the readme add information to add the repository in the composer.json :

Production build 0.71.5 2024