Unable to send email with reply-to not set error

Tested patch for the above issue

I have the same issue.
The patch fix the problem.

This patch wasn't applying cleanly for me so I updated it for latest 3.6.

My mistake, was not applying due to another patch being applied.

The last submitted patch, 4: unable_to_send_email_with_reply_to_not_set_error-3410890-4.patch, failed testing. View results →

For Acquia Platform Email, reply-to header is required or you will get this error (Amazon SES service). The patch made this work, although I do not understand why you have to uncheck 'Disable site email notification' to get reply-to to be set. Can't it just be set by default to the site mail that is sending the message out and not include the site mail as a (main) recipient?

       $recipient = '';
      $reply_to = NULL;
       if (!$notification->disableSiteMail()) {
         $recipient = \Drupal::config('system.site')->get('mail');
        $reply_to = $recipient;
    }

Why not simply $reply_to = \Drupal::config('system.site')->get('mail');?

I made the changes requested in #9

I have just come across this issue using SendGrid.

It seems it totally breaks if you check 'Disable the site email address'.

Looking at the changes here
https://git.drupalcode.org/project/content_moderation_notifications/-/me...

If the above is checked, then $recipient is always blank, which makes sense to the error I am receiving.

SendGrid\Exception\TypeException: "$emailAddress" must be a valid email address. Got: in SendGrid\Helper\Assert::email() (line 68 of /app/vendor/fastglass/sendgrid/src/Helper/Assert.php).

Drupal\Core\Entity\EntityStorageException: "$emailAddress" must be a valid email address. Got: in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 817 of /app/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

My use case is the the client does not want to receive notifications to the site wide email, and only to specific addresses, or roles.

Is anyone else seeing what I am seeing?

Drupal: 10.4.8
content_moderation_notifications: 8.x-3.7

Thanks

I managed to resolve my issue using

https://www.drupal.org/project/content_moderation_notifications/issues/3... ✨ Option to put email addresses in To: instead of in Bcc: Needs work

Yeah, I noted that in #8 https://www.drupal.org/project/content_moderation_notifications/issues/3... 🐛 Unable to send email with reply-to not set error Active