- Issue created by @koswaldk
- Assigned to chetan 11
- First commit to issue fork.
- 🇫🇷France yfiervil
It's the https://github.com/heiseonline/shariff who is in charge to add the icon on the service : https://github.com/heiseonline/shariff/blob/193cd834dedad741aeb265859516...
The class fa-twitter has to be replace by fa-x-twitter : https://fontawesome.com/icons/x-twitter?f=brands&s=solid
The request must be on the https://github.com/heiseonline/shariff and the update the readme of this module to use the right version of the library.
An issue has already been submitted to shariff's github repo. But this also requires they update to FontAwesome 6 so I'm not sure how soon we'll be seeing this.
In the meantime, here's a patch that relies on the FontAwesome's X icon added via a CSS block in the template. The code relies on svg mask since it's well supported and allows us to change the background color for the additional themes. The icon was optimized with SVGOMG and converted to Base64; after compression it should be under 500B.
Should this just be added as an asset instead?
This does not affect the internal labels. Front end label continues to be "tweet" this is coming from original library.