Account created on 8 May 2018, almost 6 years ago
#

Merge Requests

Recent comments

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Hello, same issue here. I didn't found any library able to print this calendar as PDF because it is rendered after the content is printed.

entity_print has a submodule entity_print_views to include a print button but fullcalendar_view is replacing this markup when rendering calendar.

The only way I see here is to use a client based PDF creator such as printjs, no poc on my side yet.

I think a discussion on this must be open

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Nevermind, the module is working good, I faced the issue because a project customization

πŸ‡ͺπŸ‡ΈSpain pgrandeg

After digging a little bit more, I think the issue is regarding the getFieldConfig() method.
My taxonomy vocabulary has a media file, using 'Image' media bundle. That bundle has some extra fields and as far as I have seen, the getFieldConfig() is choosing the wrong field instead of the File field.

πŸ‡ͺπŸ‡ΈSpain pgrandeg

I faced te same problem while deleting content with Drupal 10.1.7 and latest wodby/drupal-php. Disabling xdebug configuration from docker-compose.yml fixed the issue

πŸ‡ͺπŸ‡ΈSpain pgrandeg

pgrandeg β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Good catch saganakat. Merged and a new release 3.0.3 was just created. Thanks!!

πŸ‡ͺπŸ‡ΈSpain pgrandeg

pgrandeg β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Hello all,

I have been checking the patch on D10.1.5 and I found so many difficulties to make it run.
The first is that layoutcomponents has dependency on a Drupal core issue and it is not documented in project's description neither contrib documentation, so we may include it as it is resolved from core.

I included some dependencies on project's composer.json as in D10 "ckeditor" and "hal" has been removed and passed as contrib projects. Regarding this we will need to commit about the future as both will stop receiving security updates soon.

I was trying to insert some blocks on Layout Builder and I found some issues with javascript too, as jquery dependency has been removed from once: https://www.drupal.org/node/3158256 β†’
I solved it for two files lc_simple_video.js and tooltip.js and it seems to work, however I am not still being able to create components in layoutbuilder because form validations are not working properly and returned "This value should not be null." anyway when I am prompting a value.

I think there is a lot of work ahead to make it compatible this module with D10, I updated the #8 patch with the changes I mentioned before
Best, Pablo

πŸ‡ͺπŸ‡ΈSpain pgrandeg

I agree with @GuyManDude this patch solves the problem only partially.
The #11 patch works good while creating nodes, but it is crashing when you use an empty (no blocks inside) 'Tabs' region in a view mode configuration with Layout Builder.

Steps to recreate:
Create a CT
Go to Manage display use default or enable 'full'
Enable to use Layout Builder and to use LB in nodes
Configure 'default' or 'full' layout
Include a new 'Tabs' section to the layout with no content, no blocks inside
Create a new node of that CT, then you will see the error Twig\Error\RuntimeError: The callable passed to the "filter" filter must be a Closure in sandbox mode. in twig_check_arrow_in_sandbox() (line 41 of modules/layout_builder_tabs/templates/tabs.html.twig).

I have prepared a patch to set the 'tabs' $build index when it is not setted, and it works perfect in my environment.

I hope it helps

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Thank you Rajab, release 1.1.5 is working good!
https://www.drupal.org/project/bootstrap_styles/issues/3388219 πŸ› InvalidArgumentException: Invalid ID provided for the "media" entity Active

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Hello Rajab, I am using PHP 8.1.21 for both D9 and D10 websites.
I can confirm this issue is not happening in bootstrap_styles:1.1.1, but crashing on 1.1.2 and 1.1.3

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Same issue here. I opened another browser and it was working well, so I had to clear some browser data (chrome) and then it was working so good.
Thanks Chris

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Dear @abhaysaraf

I didn't want to be unpolite if I was. I meant that I wanted to be able to change project's description and change the 'Maintenance status', but I just see that you have already changed that and created a new D10 compliance release.
I think it was a missunderstanding, thank you for your support.

Best, Pablo

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Understood @gisle thank you so much

@abhaysaraf , as you will not cover this module, could you please review my last comment and bring me the possibility to edit project’s information? Thank you!

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Dear @abhaysaraf, thank you for your swift reaction

Could you please bring me module's maintainer instead of co-maintaner? In this case I will be able to edit the project and manage maintaners as well

Best, Pablo

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Thank you @abhaysaraf, I will review the issues and create a new release soon.

I think this issue may be closed

Regards, Pablo

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Thank you for the patch and the review guys

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Hello,

I offered as ColorPalette module maintainer or co-maintainer here:
https://www.drupal.org/project/projectownership/issues/3381391 πŸ’¬ Offering to maintain ColorPalette project Fixed

Regards, Pablo

πŸ‡ͺπŸ‡ΈSpain pgrandeg

I agree with @heddn, there was no new releases for more than 2 years and having a release will help to D10 implementation.
Maybe it would be a good idea to create a new branch 2.x and give support to D10 there to keep retrocompatibility with <9.5 in 1.x.
Thank you all

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Not sure if this is a module's bug. I realized that same happens if you try to delete any other field, such as body field.

Please, reopen if you find any other clue about that :)

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Hello, @sidharth_soman, I have reviewed your fixes and almost all looks okay. The only risky think I found is a missing semicolon in QuestionViewsData.php file. I fixed in my commit and included other phpcs fixes as well.

πŸ‡ͺπŸ‡ΈSpain pgrandeg

pgrandeg β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Hello apaderno,
I can apply to be virtual_keyboard maintainer, let me know if further action from my side is needed.
Thank you

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Dear @Nishant, first of all, thank you for your support

I like the logic you implemented, nevertheless there is something I think must be improved in twig file. Including css in twig files is not the best approach, so I suggest to abstract CSS code to an external css file and include into a module library.

It would be better to use flex boxes instead of floats, and to create an image style to render user profile's picture instead of rendering by CSS.

πŸ‡ͺπŸ‡ΈSpain pgrandeg

I contacted the maintainers 15 days ago and there is no response

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Dear @vjeni

I am a bit new on this module comaintenance, but as far as I know there was no plan to include that feature and it doesn't exist on latest release 1.13. Please, if you included that feature in your custom development, could you please share your code and we may merge into main branch?

Best, Pablo

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Dear @mshadem,

I am sorry for late answer. I can confirm that current release 1.13 is working as expected. Both roles are created just before enabling the module, and that roles are deleted from drupal whenever you disable the questions_answers module.

Could you please review that roles are not exported into your project config/sync dir? It may explain your issue.

Best, Pablo

πŸ‡ͺπŸ‡ΈSpain pgrandeg

I could not contact with mykola-dolynskyi, a module's maintaner, so I have contacted dobe and bribread22 last friday March 31st with no response

πŸ‡ͺπŸ‡ΈSpain pgrandeg

The module is now D9 compatible, please see the release https://www.drupal.org/project/nice_menus/releases/2.0.0-beta1 β†’

Issue: https://www.drupal.org/project/nice_menus/issues/3346832 πŸ“Œ Drupal 9 compatibility Fixed

πŸ‡ͺπŸ‡ΈSpain pgrandeg

The module is now D9 compatible, please see the release https://www.drupal.org/project/nice_menus/releases/2.0.0-beta1 β†’

Issue: https://www.drupal.org/project/nice_menus/issues/3346832 πŸ“Œ Drupal 9 compatibility Fixed

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Downgrade to 0.15.18 was the key in my case
Thank you @alex.skrypnyk!

πŸ‡ͺπŸ‡ΈSpain pgrandeg

This ticket can be closed, the patch has been applied into develop branch.
Thank you!

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Contacted @xiukun.zhou by drupal.org contact form at 2023-03-09 7:14 AM GMT+1

πŸ‡ͺπŸ‡ΈSpain pgrandeg

pgrandeg β†’ created an issue.

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Thank you @apaderno for the follow up, I forgot to change it actually.

πŸ‡ͺπŸ‡ΈSpain pgrandeg

Thank you very much in advance for your review and feedback.

Please, find below the commit where I have fixed all the topics you mentioned above:
Β· Codersniffer
Β· Remove LICENSE.txt file
Β· Consistency between composer.json and .info.yml file
Β· Remove unnecessary capital letters
Git commit: https://git.drupalcode.org/project/butler_ai/-/commit/33c7003e1c9415e296...

Production build https://api.contrib.social 0.61.6-2-g546bc20