This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #12554This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.35
- palantirnet/drupal-rector: 0.15.1
- 🇵🇹Portugal tmiguelv
Hello,
I've created a patch with additional corrections as the fixing the .info files and adding the new off-canvas selector.
Please review.
- 🇵🇹Portugal Frederico Pais Lisbon
Hello,
Following the previous patch there were some corrections that needed to be done.
I upload here the new one.Please review.
- 🇵🇹Portugal Frederico Pais Lisbon
Hello,
Further fixes were necessary on the previous comment. Added a new patch https://www.drupal.org/files/issues/2023-10-26/layoutcomponents-drupal10... →
Please review.
- 🇪🇸Spain pgrandeg
Hello all,
I have been checking the patch on D10.1.5 and I found so many difficulties to make it run.
The first is that layoutcomponents has dependency on a Drupal core issue and it is not documented in project's description neither contrib documentation, so we may include it as it is resolved from core.I included some dependencies on project's composer.json as in D10 "ckeditor" and "hal" has been removed and passed as contrib projects. Regarding this we will need to commit about the future as both will stop receiving security updates soon.
I was trying to insert some blocks on Layout Builder and I found some issues with javascript too, as jquery dependency has been removed from once: https://www.drupal.org/node/3158256 →
I solved it for two files lc_simple_video.js and tooltip.js and it seems to work, however I am not still being able to create components in layoutbuilder because form validations are not working properly and returned "This value should not be null." anyway when I am prompting a value.I think there is a lot of work ahead to make it compatible this module with D10, I updated the #8 patch with the changes I mentioned before
Best, Pablo - Status changed to Needs work
about 1 year ago 6:01pm 1 November 2023 - 🇵🇹Portugal Frederico Pais Lisbon
Hello all,
I have done quite a few more corrections to the module in order to make it drupal 10 compatible, and so I add here the latest version of the patch.
- Merge request !11Issue #3288251 by pgrandeg, Frederico Pais: Automated Drupal 10 compatibility fixes → (Merged) created by pgrandeg
-
pgrandeg →
committed ba47b70c on 3.0.x authored by
Frederico Pais →
Issue #3288251 by pgrandeg, Frederico Pais: Automated Drupal 10...
-
pgrandeg →
committed ba47b70c on 3.0.x authored by
Frederico Pais →
- Status changed to Fixed
11 months ago 7:14pm 14 December 2023 - 🇪🇸Spain pgrandeg
Release 3.0.2 created. Thank you all
https://www.drupal.org/project/layoutcomponents/releases/3.0.2 → Automatically closed - issue fixed for 2 weeks with no activity.