- Issue created by @abhaysaraf
- Assigned to nidhi27
- 🇮🇳India nidhi27
Hii,
I have created MR #8 for this functionality. After clicking on the button it will reorder based on the HSV value. Kindly review and let me know if anything else is needed.
- First commit to issue fork.
- 🇪🇸Spain pgrandeg
Hello @nidhi27, thank you very much for your contribution. I have reviewed that and I is working as expected.
I only would like to know why converting RGB to HSV in this module instead of using any external library such as https://github.com/ozdemirburak/iris/blob/master/src/Color/Rgb.php#L88.I have added some Codersniffer changes, could you please validate everything is still working as designed as double check? I will be more than happy to merge and release a new version after that. (a D11 compatible version fyi)
Thank you!
- 🇮🇳India nidhi27
HI @pgrandeg,
I have checked the code sniffer changes and its working as expected. We can go ahead.
- 🇪🇸Spain pgrandeg
Thank you @nidhi27, just merged in 1.0.x. I will check other project’s tickets and create a new release soon
Automatically closed - issue fixed for 2 weeks with no activity.