That's probably fair. I do feel like the cast shouldn't happen, but I agree that this isn't the issue to be discussing that
Hi Aman,
Since I've not heard anything back, I'm going to close the issue. If my previous comment did not help you, please feel free to create a new issue.
Alright, I've managed to force this to be reproduced. Here's what I did:
- Install the module
- Create an icon field
- Export the configuration
- Delete the file "field.storage.node.field_icon.yml"
- Remove some logic in the config importer to ignore all import errors and do it anyways
- Import the broken config
- Observe the same error
My conclusion is the following:
For some reason, your Drupal installation failed to create the field storage after creating the field. At this point, I do not know why this is. I'm not ruling out that this module is causing the issue, but I believe it to be another factor.
What you might want to try, is manually importing a "field.storage.node.field_icon.yml" file to see if that solves the issue. I've provided one (without a UUID, so it should be fine to import) for you to try. If this doesn't solve your error, at least it gets us a step further :).
Note: the file has been renamed by Drupal.org, so you want to remove the underscore after "node" from the filename before importing
Hmm, I'm not getting any errors when I try to reproduce this. I've tried reinstalling on an existing site, and installing on a clean Drupal installation. I'll go through the stack trace, to see if I can find a way to reproduce this
Hi Aman,
Thank you for reporting this issue! I will look into it.
I've created a fix for this issue. It will be available in version 1.1.3, which will be released shortly
Since there is now a Drupal 11 beta release, I have now added Drupal 11 in the .info.yml
Thank you for the detailed response. I think we have come to the same conclusion that the two projects have different approaches. I will close this issue for now, but I certainly am open for collaboration in the future if anything specific might be needed!
Hi Glyn,
Thank you for reaching out! I have come across Lupus Decoupled before, and have had it on my list of things to look at. I've now set it up locally to check it out, and I really do like what I'm seeing.
From what I have seen from Lupus Decoupled at a glance (I'm planning to play with it some more), the projects do indeed have the same goal. We just approach it from different angles. On the Nuxtify side, it's providing a batteries-included opinionated starting point, whereas Lupus Decoupled appears to be a bit more ambitious, providing deep integrations on both the Drupal and Nuxt side.
It would definitely be benificial to see what the two projects can learn from one another, since the approaches seem to complement one another quite well.
The documentation has been updated
Add documentation on the additional attributes that can now be passed to the icon
This has been implemented in https://git.drupalcode.org/project/iconify_field/-/merge_requests/13
I've added the ability to add attributes to the Twig function in https://git.drupalcode.org/project/iconify_field/-/merge_requests/11.
I've also created a follow-up issue to add some of these options to the configuration form: https://www.drupal.org/project/iconify_field/issues/3451317 ✨ It should be possible to add basic attributes to an icon Active .
This is definitely on the roadmap, but there's no reason to do it now. Once I've confirmed that it's actually stable on a D11 RC, I'll update the version
This has been fixed in https://git.drupalcode.org/project/iconify_field/-/merge_requests/10, and will be in the next release. Thank you for shopping with us
Interesting, it appears that my tools did not pick it up. I'll go for the simpler solution for now, since #3450660 ✨ Option to add attibutes in twig function Active will allow for better configuration when it's done.
That seems like a great fit for this module. I'll look into this
I've fixed the issue in https://git.drupalcode.org/project/iconify_field/-/merge_requests/9. I'll create a new release at the end of this weekend.
I do like the solution with the image mask, but it does break the selection outline of the elements in the CKEditor. I'll try a slightly different approach to solve both issues
Ah, that is something that I haven't yet tested properly. I will look into this after supper
I have no idea how to create subpages (maybe I'm not allowed). Let the full documentation live on the one page for now.
Add a tag.
Further documentation should go into further subpages
I've just released version 1.0.0-rc1, which includes this change
The has been added in v1.0.0-alpha4
Alright, understood. Thank you for the explanation. I'm looking forward to seeing the complete vision when it's ready!
Remembering that Drupal 10.3.0-beta1 has just been released also helps. I could see the problems in the Upgrade Status after updating my Drupal testing environment, and quickly fix them. The fixes have been pushed to the repo
Alright, running Rector in the terminal lets me reliably see the issues locally. Fixing and testing now
Yep, the issues still do not appear to show up in the Upgrade Status. I am running the same version as the bot, though.
Seems fair, these issues were not present when I ran the scan before. I'll make the changes manually in a bit
I've attached a pull request with what I think is the solution. To be honest, I suspect that I've not done this the right way. If something is missing, I'd be more than happy to work on it further after some pointers.
The core_version_requirement key has been updated to support Drupal 11 when it comes out. Support for Drupal 9 has also been dropped, since it is no longer supported.
Hiya @almunnings,
Thanks for the response and the quick merge! I've updated to the latest released version, and have done some tests.
Installation works fine, as does updating from the previous version. Preview tokens also get generated and read correctly.
Since the changes have been included in a new release, I'll take the liberty of closing this issue :D
Thanks again!
The issue has been fixed: https://github.com/Dobefu/nuxtify/commit/5a292953cc9c168b770b9c773ca5a5a...
I will close the ticket once the next alpha version is out.
Hi Erik, thank you for submitting this issue! The issue appears to be on the Nuxt side of things, which is in a separate repository. As such, I will create a new ticket there, so I can keep the release notes clean. I will update this ticket once it is resolved there.
The ticket can be found here: https://github.com/Dobefu/nuxtify/issues/1
I feel like this solution is not very future-proof, as it casts any data type to an integer. This would mean that the percentage would also break in the event that you set the max memory to 1GB and the amount used is in MBs. I feel like the solution would be to first parse the values to their count in bytes.
Drupal 10 compatibility has been added in the 2.x branch.