πŸ‡ΊπŸ‡ΈUnited States @gantal

Account created on 26 April 2017, over 7 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States gantal

Thank you, patch has been committed!

πŸ‡ΊπŸ‡ΈUnited States gantal

Thank you for the patch! I removed the core key but kept the core version requirement to 9.1 and above, due to the base Smart Content 3.1.x not being compatible with earlier versions.

πŸ‡ΊπŸ‡ΈUnited States gantal

gantal β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States gantal

gantal β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States gantal

The last 3 patches did not work for me on Drupal 10.1, unfortunately. I created a merge request adding simple validation before setting weights, which I belatedly realized is the same as the patch in #20.

The larger issue seems to be that locked languages (and the default language in my case) cannot be loaded as ConfigurableLanguage entities.

πŸ‡ΊπŸ‡ΈUnited States gantal

Rolled in the patch. Thanks for the help!

πŸ‡ΊπŸ‡ΈUnited States gantal

Rolled in patches and also added a missing function to ValueAB plugin.

πŸ‡ΊπŸ‡ΈUnited States gantal

Updated the info file to be compatible with Smart Content 3.1.x.

πŸ‡ΊπŸ‡ΈUnited States gantal

I had to change the compatibility to ^9.1 || ^10 because Smart Content doesn't support Drupal versions below 9.1 anymore.

πŸ‡ΊπŸ‡ΈUnited States gantal

The patch that was reviewed and tested by the community has been rolled in! The MR unfortunately has a lot of changes beyond the scope of this issue, so I'll go ahead and close it. Things like Drupal 10 compatibility are being addressed in separate issues (like πŸ“Œ Automated Drupal 10 compatibility fixes Needs review )

πŸ‡ΊπŸ‡ΈUnited States gantal

I had to change the usage of Context to ContextAwarePluginTrait and make a few other tweaks to get this to properly work with Drupal 10. I see that 2 tests are still failing but I've merged the MR for this issue so that we can get a D10-compatible release out as soon as possible.

πŸ‡ΊπŸ‡ΈUnited States gantal

gantal β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024