shaunole β created an issue.
I've created "MR !25" for the provided patch in addition to my previous comment that sets `display:flex` to `display:flex!important`.
The patchfile for this MR can be found here: https://git.drupalcode.org/issue/bootstrap_layout_builder-3335356/-/commit/2c6bcfdeae304f838157fabfe88e8168c2bfecd5.patch.
Changing status back to Needs Review as a new Patch/MR have been submitted.
Hope this helps!
The issue that we're seeing with the layout builder UI is due to the a Drupal Core CSS rule for the drupal-off-canvas-wrapper setting the label's display to "inline" (see line 105 of: /core/misc/dialog/off-canvas/css/form.css
) as shown here:
:is(#drupal-off-canvas-wrapper input[type="checkbox"]) + label,
:is(#drupal-off-canvas-wrapper input[type="radio"]) + label {
display: inline;
}
In order for Bootstrap Layout Builder's display of "flex" to persist, the CSS display attribute found in: bootstrap_layout_builder/css/layout-tab-styles.css
would need to be more specific or need to be indicated as 'important'. I'm working on a temporary patch/solution for this and will post shortly.
No issues found when testing//validating @vlad.dancer 's MR !55 against the 1.0.x branch. Updating status to RTBC
Seems like the error still exists after patching via composer. I've confirmed that the patch correctly changed ??
to ?:
. The tests passed, so it appears more testing may be necessary.
No problem @luke.leber. I was reviewing my commit in GitLab and initiated the Merge Request there instead of in this issue. Perhaps it was not triggered due to the steps I took to create it.
Created issue fork and MR to update the null-coalesce operator to a short-hand ternary as suggested by Luke.Leber. PRetty simple change that I can confirm resolved the issue on my end.
shaunole β made their first commit to this issueβs fork.
Adding a related issue where the composer.json file has been patched via MR and is awating review and hopeful merge/release.
Rebased previous commit in issue fork against 2.x.
shaunole β made their first commit to this issueβs fork.
After verifying that all pending database updates had been completed, I found that the mailer_html_to_text
configuration still existed via:
drush cget symfony_mailer.mailer_policy._ configuration.mailer_html_to_text
I was able to resolve this in drush by deleting said configuration and rebuilding cache:
drush cdel symfony_mailer.mailer_policy._ configuration.mailer_html_to_text
drush cr
I can confirm seeing this issue as well. Performing a cache rebuild prior to the update had no effect on the result.
I can confirm that I was able to reproduce the reported issue and the MR resolved it.
It appears this module is only set up to evaluate US-based taxes. This being the case, we should only evaluate the taxes if the country_code for the tax address is 'US'. Created a MR to fix this oversight.
shaunole β made their first commit to this issueβs fork.
volkswagenchick β credited shaunole β .