🇷🇴Romania @bogdan.dinu

Account created on 7 September 2016, about 8 years ago
#

Recent comments

🇷🇴Romania bogdan.dinu

Patch #13 doesn't work when using installing from dist (possibly because of a conflict with the version information that the drupal.org packager adds to theme_filter.info.yml) but it works when using installing from source.

Just add the code below in your composer.json under config:

        "preferred-install": {
            "drupal/theme_filter": "source",
            "*": "dist"
        }
🇷🇴Romania bogdan.dinu

I've updated the patch to prevent triggering change on child elements when "parents only" option is enabled otherwise it renders the widget almost unusable when ajax is enabled and the item has many children.

🇷🇴Romania bogdan.dinu

I've updated the patch to also show the child elements as checked and also replaced the control_id to use the attribute "data-drupal-selector" instead of "id". This way the code also works if the widget is reloaded with ajax.

🇷🇴Romania bogdan.dinu

For anyone looking for a way to attach files to emails, I've updated the patch to work with symfony_mailer.

🇷🇴Romania bogdan.dinu

The warning still exists on Drupal 10 with php 8.1 and viewsreference 2.0-beta6.
I attached a patch that fixes the issue in \Plugin\Field\FieldType\ViewsReferenceItem and Plugin\Field\FieldFormatter\ViewsReferenceFieldFormatter as they are using the 'data' array key without checking if it is set.
PS: the warning is generated only for the FieldType but I think adding the check for the FieldFormatter doesn't hurt :)

🇷🇴Romania bogdan.dinu

I've created a patch that searches for extensions in the base themes of the active theme as well.

🇷🇴Romania bogdan.dinu

Previous patch added third level items as top level items. I created a new patch to fix it.

🇷🇴Romania bogdan.dinu

Hi! Thank you so much for the help! The patch works and all mismatched documents are gone.
I already had something similar implemented in the the getOriginalObject method.
As you said, better to have a small performance decrease and no duplicates/omissions in search results :)

I'll try to do some debugging to get to the root couse of the issue.

🇷🇴Romania bogdan.dinu

Hi @DonAtt,

Changing window.location.pathname with url.pathname breaks embedded views. If you have the view and the facets embedded in a page, your code will push in history the url of the view not the url of the current page.
I think you should find a way to manage the parameters needed by Facets Pretty Paths in the url.search variable.

🇷🇴Romania bogdan.dinu

This is still an issue because there is no check on the value that is given to strtotime on line 155.
I attached a patch with a fix.

🇷🇴Romania bogdan.dinu

Updated patch that clears the query and fragment for non reference links.

🇷🇴Romania bogdan.dinu

The previous patch is incomplete. I appologize!
I uploaded a new one (it is based on the patch from #7).

🇷🇴Romania bogdan.dinu

I don't think the proposed solution is ok because it is saving the query and fragment in the uri. That is not compatible with the core link schema or other modules that use the core link schema.
I propose saving the query and fragment in the options base field of the link field as described in the core link schema.
My solution only works with the patch from this issue on linkit_field https://www.drupal.org/project/linkit_field/issues/3349013 🐛 Preserve query parameters and fragments when directly inputting a path. Active
because the linkit widget from linkit doesn't use the node path/alias.

🇷🇴Romania bogdan.dinu

I also ran into this issue recently and I think the best option would be to enable the language option on the link widget.
The link field supports for the language option and it will automatically generate the link in the selected language. The language selector can default to the current page language but the user will have the possibility to change it.
Unfortunately I didn't have time to implement it yet.

🇷🇴Romania bogdan.dinu

I think this is related to https://www.drupal.org/project/paragraphs/issues/2905264 🐛 Deleted Paragraphs visible in drag & drop Needs work
If opsolete paragraphs are not visible anymore there is no need to have delete actions in the drag&drop mode.

🇷🇴Romania bogdan.dinu

The getChildParagraphs method in src/Plugin/Field/FieldWidget/ParagraphsWidget.php reconstructs the paragraphs from the form state storage but it doesn't take into account deleted paragraphs.
I added a simple check to fix the issue.

I changed the issue priority to major because clicking "Complete drag & drop" will restore the deleted paragraph which creates data inconsistency.

🇷🇴Romania bogdan.dinu

I updated the patch to make it work for views embeded as blocks. The pushstate was changing the URL to the views page URL.
I've added support for pushstate navigation. The reload workaround only worked for one history iteration.
I've also included @jmaerckaert's latest update for the facets summary.

🇷🇴Romania bogdan.dinu

I've updated the last patch with a simple check on the default value for the form element because it was throwing a warning (Undefined array key "use_current_language").

🇷🇴Romania bogdan.dinu

@smustgrave unfortunately no. I don't know where this was fixed. I just tried locally on D9.4 without the patch and saw that there is no more data loss.

Production build 0.71.5 2024