Montreal
Account created on 5 August 2016, almost 8 years ago
  • Drupal Developer at SymetrisΒ  …
#

Merge Requests

More

Recent comments

πŸ‡¨πŸ‡¦Canada ksere Montreal

Adjusting text to be less confusing.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Adjusted formulation of text surrounding loading order to avoid confusion.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Good to go in release 1.0.0-alpha2.

We can open a new issue if what was discussed in #2 & #4 becomes a need down the line.

πŸ‡¨πŸ‡¦Canada ksere Montreal

That's fine! I've gone ahead and opened a merge request with the work done so far. I think it's a good first version to at least support field group integration.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Took a look, tested it, and I think what was done was already sufficient.

When choosing to render a field group as a component, I don't think we need to look for files for each field. This is because the group as a whole will be rendered as the component, and all needed preprocessing should be able to be achieved within the one file. In the loaded file we'll have access to all props and slots for the given group.

Did you think of a use case where individual files would be needed? I might be missing something.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Will be closing this now, it's merged into 1.0.x-alpha1!

πŸ‡¨πŸ‡¦Canada ksere Montreal

This is a good idea since field_group is a popular module and is used often with SDC.

I'll continue off what you started and perform some tests.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Comparison looks good to me. Green light for a merge request to be created!

πŸ‡¨πŸ‡¦Canada ksere Montreal

I'll be taking this as part of a Symetris contribution workshop.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Fixed some more typos.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Fixed a typo in the documentation.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Slight wording change in snippet.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Added link to plugin properties documentation.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Fixed link in first sentence.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Adjusted weight of the menu item.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Adjusted erroneous loading order.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Added a comparison to a traditional hook.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Added a mention for YAML discovery in modules.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Replaced bold text with code text.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Slight change in wording for better explanation.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Adjusted the section title.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Added a summary section.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Added link to module page in title.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Added section explaining that files are loaded from modules as well.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Minor cleanup.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Slight modification to the title of this page to fit with the menu link title.

πŸ‡¨πŸ‡¦Canada ksere Montreal

2.x will be abandoned. This error should not occur in 3.x and above.

πŸ‡¨πŸ‡¦Canada ksere Montreal

2.x will be abandoned unfortunately in favor of 3.x, where test modules will be completely rewritten.

That being said, thank you for the work so many months ago.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Will focus on coding features into this module instead as the core methods to achieve the functionality is much different than Preprocess albeit the same goal being achieved.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Taking this issue as part of a Symetris contrib session.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Released as part of version 1.0.3.

πŸ‡¨πŸ‡¦Canada ksere Montreal
πŸ‡¨πŸ‡¦Canada ksere Montreal
πŸ‡¨πŸ‡¦Canada ksere Montreal

Looks good! Will be merging this shortly.

Thank you!

πŸ‡¨πŸ‡¦Canada ksere Montreal

Good catch. Change has been committed in the fork.

Will be merging this soon.

πŸ‡¨πŸ‡¦Canada ksere Montreal

ksere β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Released as part of 1.0.0-rc1.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Released as part of 1.0.0-rc1.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Released as part of 1.0.0-rc1.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Help hook has been added with base documentation.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Help hook will be added shortly.

πŸ‡¨πŸ‡¦Canada ksere Montreal

ksere β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Committed a fix into 1.0.x for this.

.idea has been removed and there are no longer line lengths

πŸ‡¨πŸ‡¦Canada ksere Montreal

Tested and pushed fix into 1.0.x.

The module now declares a dependency on versions 4, 5 or 6 of symfony/filesystem via its own composer.json file.

πŸ‡¨πŸ‡¦Canada ksere Montreal

PHPCS is treating the README file like a PHP file. Autofixing will add unwanted code and changes to the README.

I will however remove .idea and reduce lines to below 80.

πŸ‡¨πŸ‡¦Canada ksere Montreal

ksere β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada ksere Montreal

This is due to a missing dependency on the symfony/filesystem package.

I will include a composer.json file to address this.

πŸ‡¨πŸ‡¦Canada ksere Montreal

ksere β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Got a working solution that fits the proposed resolution.

Note that Users and Profiles are two distinct entity types.

For Profile entity types, the terminology profile type is used as that is the name of the bundle.

For User entity types, there is no bundle. I've opted to default to entity type for this case. It's generic and is still appropriate Drupal terminology.

New Status Messages

User

The field Test has been deleted from the User entity type

Profile Types

The field Testhas been deleted from the Main profile type.

Block Types

The field Testhas been deleted from the Basic block type.

Comment Types

The field Testhas been deleted from the Default comments comment type.

Content Types (Unchanged)

The field Testhas been deleted from the Article content type.

Media Types

The field Testhas been deleted from the Audio media type.

Vocabularies

The field Testhas been deleted from the Tags taxonomy vocabulary.

πŸ‡¨πŸ‡¦Canada ksere Montreal

Simply rebased the branch @bcgreen created for now.

πŸ‡¨πŸ‡¦Canada ksere Montreal

ksere β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada ksere Montreal

ksere β†’ created an issue.

πŸ‡¨πŸ‡¦Canada ksere Montreal

2.x has been discontinued. 3.x & 4.x are successfully compatible with D10.

Closing this as wontfix.

Production build 0.69.0 2024