πŸ‡ΊπŸ‡ΈUnited States @sjmolinski

Account created on 22 June 2016, over 8 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States sjmolinski

I have tested the branch, and it is working as expected.

I did notice two small things that could be part of a separate ticket. The in-code documentation mentions that the structure should be like this:

  /*
   * This registers the structure that will be seen by CKEditor 5 as
   * <uswdsGrid>
   *    <uswdsGridContainer>
   *      <uswdsGridRow>
   *        <uswdsGridCol .. />
   *      </uswdsGridRow>
   *    </gridContainer>
   * </bootstrapGrid>
   * ...
   */

Is uswdsGridContainer used, or is it redundant for uswdsGrid? Is there special cases where it is needed?

The second thing is that I see 'undefined' values in the class attribute of the uswdsGrid:

πŸ‡ΊπŸ‡ΈUnited States sjmolinski

I recently became aware of this issue and will take a look.

πŸ‡ΊπŸ‡ΈUnited States sjmolinski

I have a patch here that should provide the context for the jQuery selector so that it only select accordions inside of the <main> This is my first time contributing and would love any feedback.

Production build 0.71.5 2024