USWDS Grid not working

Created on 17 October 2023, about 1 year ago
Updated 9 November 2023, about 1 year ago

USWDS grid disappears while editing the page

Add a grid and save the page. Edit the page and the grid disappears and even in the source code the grid container is empty.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @irsar
  • πŸ‡ΊπŸ‡ΈUnited States sjmolinski

    I recently became aware of this issue and will take a look.

  • First commit to issue fork.
  • @smustgrave opened merge request.
  • Status changed to Needs review about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Try this.

    Ignore the phpstan stuff. I'll fix that in a separate issue.

  • πŸ‡ΊπŸ‡ΈUnited States sjmolinski

    I have tested the branch, and it is working as expected.

    I did notice two small things that could be part of a separate ticket. The in-code documentation mentions that the structure should be like this:

      /*
       * This registers the structure that will be seen by CKEditor 5 as
       * <uswdsGrid>
       *    <uswdsGridContainer>
       *      <uswdsGridRow>
       *        <uswdsGridCol .. />
       *      </uswdsGridRow>
       *    </gridContainer>
       * </bootstrapGrid>
       * ...
       */
    

    Is uswdsGridContainer used, or is it redundant for uswdsGrid? Is there special cases where it is needed?

    The second thing is that I see 'undefined' values in the class attribute of the uswdsGrid:

  • Status changed to RTBC about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States sjmolinski
  • Status changed to Fixed about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024