- Issue created by @irsar
- πΊπΈUnited States sjmolinski
I recently became aware of this issue and will take a look.
- First commit to issue fork.
- @smustgrave opened merge request.
- Status changed to Needs review
about 1 year ago 12:36am 9 November 2023 - πΊπΈUnited States smustgrave
Try this.
Ignore the phpstan stuff. I'll fix that in a separate issue.
- πΊπΈUnited States sjmolinski
I have tested the branch, and it is working as expected.
I did notice two small things that could be part of a separate ticket. The in-code documentation mentions that the structure should be like this:
/* * This registers the structure that will be seen by CKEditor 5 as * <uswdsGrid> * <uswdsGridContainer> * <uswdsGridRow> * <uswdsGridCol .. /> * </uswdsGridRow> * </gridContainer> * </bootstrapGrid> * ... */
Is uswdsGridContainer used, or is it redundant for uswdsGrid? Is there special cases where it is needed?
The second thing is that I see 'undefined' values in the class attribute of the uswdsGrid:
- Status changed to RTBC
about 1 year ago 5:18am 9 November 2023 - Status changed to Fixed
about 1 year ago 3:04pm 9 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.