Account created on 25 August 2015, over 9 years ago
#

Merge Requests

Recent comments

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

We had the same problem and it seems like patch #3 worked for us.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

That update was somehow missing.
Now it works for some cases. But not for every content type.
But I don't know yet why some content types have scores and some don't.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

/sites/default/files/foo.jpg - This gets 404 as it should.
/sites/default/files/js/foo.jpg - This gets 400 and the client error page and Drupal writes to the logs client error. Anything not existing in the JS and CSS folder is causing that problem (/sites/default/files/js/error.exe). It's not about file types. Drupal not handling correctly not existing files in these folders.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

Tested with the latest Drupal 10.1.7
[ANY D10.1 SITE]/sites/default/files/css/foo.css -> 400 "A client error happened"
Why it can't be a normal 404 file not found?

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

We got the same issue from today.
Getting it after drush cr command.
If I do drush cim then 1 time it's clean and I can run any command.
After that, I'm getting again this error.

The only solution at the moment is to uninstall webprofiler and tracer.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

overall_score.html.twig file contain

<div {% if overall_score_target_id %}id="{{ overall_score_target_id }}"{% endif %}
     class="overallScore {{ overall_score|clean_class }}">
    <span class="score_circle"></span>
    <span class="score_value">{{ overall_score }}</span>
</div>

When I remove that "clean_class" from here then I don't have that issue anymore.
When we add "clean_class" and later try to update the value and use "overall_score" as an indicator then these 2 values can not match in some cases.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

That issue is coming from Drupal translation.
When I change that field back to English then there is no issue.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

Issue is coming from the yoast_seo.js file line 305

    // We convert the label to lowercase here, which is not as good as clean_css that's being called on the back-end,
    // but is good enough for the constraints on the classes we use.
    scoreDisplay.classList.remove(scoreLabel.innerHTML.toLowerCase());

Content of scoreDisplay.innerHTML is:

    <span class="score_circle"></span>
    <span class="score_value">μ•Œ 수 μ—†μŒ</span>
πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

I got the same error when the content was in the Korean language.
Uncaught DOMException: Failed to execute 'remove' on 'DOMTokenList': The token provided ('μ•Œ 수 μ—†μŒ') contains HTML space characters, which are not valid in tokens.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

It will be really very nice to get that release and avoid adding all those fixes with patches.
Thank you all for the work you have done here.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

I just did a re-write to the D9 version of the patch so it will apply to the D10.
No changes in functionality.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

I think that issue priority should be higher because without that patch access page is broken for every single node.
#8 patch seems to fix that issue.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

Coding standard fixes to the last patch #5.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

Now database update script is included in this patch to update existing values.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

Thank you for that hint.
That fix I did only make the content access page visible but we need all the similar work that is done for D7 also for D8 version.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

Is any release date planned for that fix?

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

Found same errors on my log file.
Which patch works here, the latest #8?

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

When I re-run the Upgrade Status scan after the 2.23 update I still got 8 issues left there.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

This swagger-codegen will also need updating. The current version seems to be form 2018.

πŸ‡ͺπŸ‡ͺEstonia mikkmiggur

mikkmiggur β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024