Empty "page" argument leads to php error

TypeError: Drupal\simple_sitemap\Manager\Generator::getContent(): Argument #1 ($delta) must be of type ?int, string given, called in /app/web/modules/contrib/simple_sitemap/src/Controller/SimpleSitemapController.php on line 61 in Drupal\simple_sitemap\Manager\Generator->getContent() (line 139 of /app/web/modules/contrib/simple_sitemap/src/Manager/Generator.php) #0 /app/web/modules/contrib/simple_sitemap/src/Controller/SimpleSitemapController.php(61): Drupal\simple_sitemap\Manager\Generator->getContent('') #1 [internal function]: Drupal\simple_sitemap\Controller\SimpleSitemapController->getSitemap(Object(Symfony\Component\HttpFoundation\Request), 'default')

Comments & Activities

Issue created by @adamzimmermann
Merge request !54Issue #3338719: Empty "page" argument leads to php error → (Closed) created by adamzimmermann
Status changed to Needs review almost 2 years ago8:39pm 2 February 2023
Comment almost 2 years ago →
🇺🇸United States adamzimmermann
I just attached some screenshots of the before and after based upon some local testing.
Comment almost 2 years ago →
🇩🇪Germany gbyte Berlin
That's major, thanks for catching it! Please open up bug reports against the dev version only.

Comment almost 2 years ago →

System Message

gbyte → committed 90bfa5c8 on 4.x

Issue #3338719 by adamzimmermann, gbyte: Empty "page" argument leads to...

Status changed to Fixed almost 2 years ago9:22pm 2 February 2023
Comment almost 2 years ago →
🇩🇪Germany gbyte Berlin
Would you agree casting to int is an elegant fix in this case? If not, feel free to reopen the issue.
Comment almost 2 years ago →
🇺🇸United States adamzimmermann
I like it. Thanks for the quick response and getting this committed.

I just confirmed that worked locally too.

Comment almost 2 years ago →

System Message

gbyte → committed e5667a0f on 4.x

Issue #3338719 by adamzimmermann, gbyte: Empty "page" argument leads to...

Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Status changed to Fixed over 1 year ago6:39am 6 June 2023
Comment over 1 year ago →
🇪🇪Estonia mikkmiggur
Found same errors on my log file.
Which patch works here, the latest #8?
Comment over 1 year ago →
🇩🇪Germany gbyte Berlin
@mikkmiggur Just use the development version of this module for now. This fix is also going to be included into the next release.
Comment 6 months ago →
System Message
WalkingDexter → closed merge request !54

Empty "page" argument leads to php error

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!54Empty "page" argument leads to php error
Closed

Comments & Activities

Empty "page" argument leads to php error

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!54Empty "page" argument leads to php errorClosed

Comments & Activities

!54Empty "page" argument leads to php error
Closed