I'm facing uninstall issues with version 3.0.1, but when I try to use patch #5, I get message "Unreversed (or previously applied) patch detected!" (this also happens for latest dev-version). Does this mean, the patch is already incorporated?
Same here on Drupal 10.4.3 Commerce 8.x-2.4. The warning appear on the page, for logged-in and anonymous users:
Warning: Undefined property: Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\MultistepDefault::$order in Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowBase->getOrder() (line 167 of modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowBase.php).
Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowBase->getOrder() (Line: 233)
Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowBase->getStepId() (Line: 50)
Drupal\commerce_checkout\CheckoutOrderManager->getCheckoutStepId() (Line: 94)
Drupal\commerce_checkout\Plugin\Block\CheckoutProgressBlock->build() (Line: 171)
Drupal\block\BlockViewBuilder::preRender()
call_user_func_array() (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback() (Line: 870)
Drupal\Core\Render\Renderer->doCallback() (Line: 432)
Drupal\Core\Render\Renderer->doRender() (Line: 504)
Drupal\Core\Render\Renderer->doRender() (Line: 248)
Drupal\Core\Render\Renderer->render() (Line: 484)
Drupal\Core\Template\TwigExtension->escapeFilter() (Line: 100)
__TwigTemplate_130ea0b20e16b7458dc8789110f80010->doDisplay() (Line: 388)
Twig\Template->yield() (Line: 344)
Twig\Template->display() (Line: 359)
Twig\Template->render() (Line: 51)
Twig\TemplateWrapper->render() (Line: 33)
twig_render_template() (Line: 348)
Drupal\Core\Theme\ThemeManager->render() (Line: 491)
Drupal\Core\Render\Renderer->doRender() (Line: 248)
Drupal\Core\Render\Renderer->render() (Line: 484)
Drupal\Core\Template\TwigExtension->escapeFilter() (Line: 91)
__TwigTemplate_80e4a832c064768b4b184dd17715a366->doDisplay() (Line: 388)
Twig\Template->yield() (Line: 344)
Twig\Template->display() (Line: 359)
Twig\Template->render() (Line: 51)
Twig\TemplateWrapper->render() (Line: 33)
twig_render_template() (Line: 348)
Drupal\Core\Theme\ThemeManager->render() (Line: 491)
Drupal\Core\Render\Renderer->doRender() (Line: 248)
Drupal\Core\Render\Renderer->render() (Line: 158)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 153)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
call_user_func() (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (Line: 186)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)
Thank you, agoradesign, I'm sorry, the fault was on my side — plugin works like a charm indeed!
I tested the issue on several fresh and clean installs — with german locale, issue is always occuring.
Just use this DDEV recipe:
mkdir testsite-german && cd testsite-german
ddev config --project-type=drupal10 --docroot=web
ddev start
ddev composer create drupal/recommended-project:^10
ddev composer require drush/drush
ddev drush site:install --account-name=admin --account-pass=admin --locale=de -y
ddev launch
ddev composer require 'drupal/mail_login:^4.0'
ddev drush pm:enable mail_login
ddev launch $(ddev drush uli)adam1 → created an issue.
+1 on this!
This feature would be so helpful!
For book stores, for example, it would be great being able to reference paid product variations (e.g. printed books) as well as free variations (e.g. open access books for direkt download w/o checkout) from the same product display. Waiting ages for such a feature!
+1
Thank you for clarifying!
I'm looking forward for a stable D10 release as well!
Hello, thanks for the wonderful module! When will you release an official D10 release of it — seems like the most work is done, isn't it?
I'm going to set up a book shop with Drupal 10, which offers printed books and open access books for download, so I came across this issue. Can some one tell me if this patch is incorporated in Drupal 10 or do I have to patch? Since it's a community project that has not much funding, I don't like to do patches because future maintenance may get harder.
We patched the isotope.module file to get rid of the issue. Attached it here.