sonvir249 → made their first commit to this issue’s fork.
@hosisam Thanks for this patch.
sonvir249 → created an issue.
@govind_giri_goswami Thanks for creating this issue and the patch, but this seems to be working as expected. `getLanguages()` returns array of active languages which includes default languge. Hence it can not be empty.
Please check - https://api.drupal.org/api/drupal/core!modules!language!src!Configurable...
Feel free to re-open the issue.
@apaderno how can I fix this?
sonvir249 → created an issue.
@vishal.kadam Thanks for the feedback. I have updated the module as per changes suggested.
sonvir249 → created an issue.
sonvir249 → changed the visibility of the branch 3418124- to hidden.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → made their first commit to this issue’s fork.
Fixed the errors mentioned in #25
sonvir249 → made their first commit to this issue’s fork.
@greg-boggs I have updated the MR as per the changes suggested.
sonvir249 → created an issue.
sonvir249 → changed the visibility of the branch 8.x-3.x to hidden.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → made their first commit to this issue’s fork.
@Damien I created a issue here - https://www.drupal.org/project/projectapplications/issues/3402595 → .
@apaderno Module https://www.drupal.org/project/ckeditor_html_embed → does not contains php code but still it is covered by the security advisory policy.
@apaderno This module serves as a straightforward CKEditor 5 plugin, encompassing essential code for CKEditor 5 plugin functionality. To ensure comprehensive security coverage, what additional steps can I take to formally enroll this module in the security advisory program?
Thanks @vishal.kadam for the review. I have pushed 1.x branch.
sonvir249 → created an issue.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → created an issue.
sonvir249 → created an issue.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → created an issue.
@greg-boggs created a merge request. This might need a new release for Drupal 9 and D10. accessCheck() will fail for Drupal 8
sonvir249 → made their first commit to this issue’s fork.
@greg-boggs I have created a MR, and pushed all the phpcs fixes.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → created an issue.
@monymirza in V2 stable branch file names are `fractionslider.info.yml`, `fractionslider.libraries.yml` and `fractionslider.module`. It sould follow the module directory name.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → made their first commit to this issue’s fork.
test comment
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → made their first commit to this issue’s fork.
sonvir249 → created an issue.
The approach in #19 worked for me.
baikho → credited sonvir249 → .
sonvir249 → made their first commit to this issue’s fork.
@brianperry Yes, the patch is only for Drupal 10. Having a separate branch for Drupal 10 is a good idea. This way it will be compatible with both Drupal 9 and Drupal 10