- Status changed to RTBC
over 1 year ago 2:24pm 25 June 2023 - 🇮🇳India Bushra Shaikh
I have reviewed and checked patch#5 this works for Drupal 9.5 and Drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 have been attached for reference:Can be move to RTBC+1
- 🇺🇸United States Greg Boggs Portland Oregon
This needs a reroll. If we open it as an MR instead of patches, I can merge it same day.
1 out of 1 hunk FAILED -- saving rejects to file src/AlinkPostRenderer.php.rej
- First commit to issue fork.
- @sonvir249 opened merge request.
- Status changed to Needs review
over 1 year ago 2:05am 7 September 2023 - 🇮🇳India sonvir249 Pune
@greg-boggs created a merge request. This might need a new release for Drupal 9 and D10.
accessCheck()
will fail for Drupal 8 -
Greg Boggs →
committed 2376336c on 2.x authored by
sonvir249 →
Issue #3286036 by sonvir249, yogeshsevak, Bushra Shaikh, Greg Boggs:...
-
Greg Boggs →
committed 2376336c on 2.x authored by
sonvir249 →
- Status changed to Fixed
over 1 year ago 2:41am 7 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 6:54pm 1 November 2023 - 🇺🇸United States mihaic
Hi here patch #5 completed with another access check to avoid error "Entity queries must explicitly set whether the query should be access checked or not." on Drupal 10
- 🇺🇸United States Greg Boggs Portland Oregon
Hi @mihaic,
This has already been committed and is available in the latest dev release of alinks. Can you give the dev release a try in Drupal 10 and let me know if it works?
hello @greg-boggs
If I open this release https://www.drupal.org/project/alinks/releases/2.x-dev →
and check the file, these changes are not present.
so it seems the changes have not been implemented.I added the implementation of trustedcallback as described here:
https://www.drupal.org/project/alinks/issues/3171893#comment-15378255 🐛 ALinks causes security exception after Drupal 8.8 Needs workand I implemented the changes from #15 in this thread.
there are no more errors, but the module does not work, no Keyword replacement are being done, what could be the problem ?
- 🇺🇸United States Greg Boggs Portland Oregon
The commit is here:
https://git.drupalcode.org/project/alinks/-/commit/2376336caad43298705f4...
I am not sure what's going on with the release file for the 2x branch, but all commits to the 2x branch should be in it unless there's an infrastructure problem.