- Issue created by @sonvir249
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.3 & MySQL 5.7last update
10 months ago Waiting for branch to pass - Status changed to Needs review
10 months ago 5:30pm 29 January 2024 - Issue was unassigned.
- Status changed to RTBC
9 months ago 12:51pm 1 March 2024 - 🇫🇷France S3b0uN3t Nantes
Tested with version 3.8 of the AMP module in PHP 8.3.
The Merge Request resolves the deprecated issue and does not result in a new issue.I update the issue in RTBC.
Thanks for your fix !
- 🇺🇸United States kurttrowbridge
Also confirmed that the supplied MR resolved the issue for my site using PHP 8.2 and the dev version of the module. Thank you!
- 🇧🇪Belgium flyke
After this patch, I got the following notices in my console after for example a
drush updbcommand:PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/lullabot/amp/src/AMP.php on line 356 Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/lullabot/amp/src/AMP.php on line 356 PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/lullabot/amp/src/AMP.php on line 357 Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /var/www/html/vendor/lullabot/amp/src/AMP.php on line 357I fixed this by adding this patch in my projects composer.json file:
"lullabot/amp": { "#317": "https://patch-diff.githubusercontent.com/raw/Lullabot/amp-library/pull/317.patch" }