onfire84 → created an issue.
onfire84 → made their first commit to this issue’s fork.
onfire84 → created an issue.
onfire84 → created an issue.
onfire84 → made their first commit to this issue’s fork.
onfire84 → created an issue.
Tryed Patch #86 on a 10.2.x Drupal Page. Patch does apply, but when i try to configure a block on the blocklayout page, it fails with "Error: Undefined constant "Drupal\block\form_state" in Drupal\block\BlockForm->buildVisibilityInterface() (line 242 of core/modules/block/src/BlockForm.php)."
I tryed it on a fresh drupal 10 installation. Could also not reproduce the issue.
sanduhrs → credited onfire84 → .
I did rerun the hook and exportet the config changes again. Seams to be fixed.
Hi, i ran into the same issue this week and will try to write a patch for that.
onfire84 → made their first commit to this issue’s fork.
sanduhrs → credited onfire84 → .
I just tryed an upgrade vom 11.9.x to 12.0.0-rc6 and got the same error message.
Great to see this fixed!
Would it be possible to have a new release here? I feel a bit uncomfortable to use a dev version in production.
+1 for a new Release
I will close this issue. Debugging the datebase update leads me to a deprecated module in our setup that breaks the schema update. The update itself runs as designed after uninstalling the other module.
I tryed the patch, it works as expected. Thank you!
onfire84 → created an issue.
I tried to apply the changes from the MR as a composer patch. But it will fail. I had a Drupal 10.1.5 installation with DFP 2.0.0-alpha1 runing on PHP 8.2.
onfire84 → created an issue.
Works as expected. Thank you.
onfire84 → created an issue.
I will review this during the contribution session at DrupalCon Lille today.
Here is the patch. Would be nice if someone could review it. Thanks.
I will fix it and provide a patch.
onfire84 → created an issue.
Hi, i updated the patch to work with latest dev. It should also apply now again if you try to use it with 2.1.x
Thanks for your patch. The changes look good to me.