References are broken

Created on 29 January 2024, over 1 year ago

Problem/Motivation

I believe that this change introduced in https://www.drupal.org/project/group_term/issues/3367570 Add Group Ids to the Taxonomy Terms Fixed are causing a couple of issues.

1. https://www.drupal.org/project/group/issues/3398778 🐛 Unknown column group_relationship_field_data.tid in 'on clause Needs review
This seems to be a regression caused by this. The fix they are working on is actually doing it's job preventing the fatal error on the term relations overview view, but this is just a workaround.

2. On top there is a regression with filtering out Terms on the "Add existing Term" page, where you have an autocomplete field for adding existing Terms to the group. This thing will now only show Terms that already belong to the group which makes it unsuable - therefor declaring this issue as a bug.

Steps to reproduce

Just install latest Version of Group and Group Term. Both issues should be reproduceable out of the box.

Proposed resolution

Undo the changes from https://www.drupal.org/project/group/issues/3398778 🐛 Unknown column group_relationship_field_data.tid in 'on clause Needs review
This issue can be solved by creating a view only showing the terms related to the group and using this as a selection handler setting. Eventually I will contribute a module providing a selection handler doing this out-of-the-box but we cannot do this on an API level without breaking the Add existing Terms feature.

🐛 Bug report
Status

Active

Version

4.1

Component

Code

Created by

🇩🇪Germany Hydra

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024