🇺🇦Ukraine @t1mm1

Hi,

added patch for 6.2.7

I will add patch here with this form. You can check it and see, maybe, it will change your opinion. Cause in my case configs update not usabble. I understand that you propouse most easy way yo config it, I agree with you cause it's good when you have several sites in support (for example). In my case I want to see it in maximum UI intergation.

Anyway, thanks for your solution and time. Your 'menu tree' is really cool module and we use it as well.
Thanks.

"This is not true. You can just edit the menu_tree.settings.yml in your config folder and add all the bundles you want using the menu tree widget. Don't forget to import the config after (drush cim)."

So, just imagine. You working in company that has 100+ clients. A lot of them sometimes make updates - they create a custom node types. How many hours will be spend to update/export/import configs and re-deploy on dev, stage and product? In your case you should support each client env manually.

No problem. I just propouse a typical solution related to drupal way.
Thanks for feedback.

Updated for 1.0.2

in short: no changes in the patch
thanks!

Updated patch for 1.0.2.

Hi, Peter.
In current implementation menu tree works for the 'page' bundle only. For example. if you create a new one custom bundle for node - it will not work there at all. It's from the box.
I just propouse to upgrade settings for it. The config will be same. Just settings form and save process that will update config. It's not about minor changes. It's about enhancement. In will not break existing installations because there is no settings at all. And just 'page' bundle supporting only.

Lemme explaine some my expirience. Some customes wants to use it for selected bundles, not for all. And keep some bundles with default menu link creation. I think it's good point when customer can select bundles for menu tree.

My patch is not same, nut it provide to use menu tree for all bundles.

Thanks.

Patches for v 1.0.0 and 1.0.2
Related to the files changes (patches has no different) it can me apply to the 1.0.1 as well.

I did test it on D 10.2.7 version.

Thanks.

Up!

First of all, thanks @peter törnstrand for your feedback.

I did add some details.
The main point to reproduce is to reoder the template from module in the custom theme. My mistake was that I forget add this point before.

As solution I propouse to add missed default values into theme_hook
See my patch for 1.0.0 version. Will create for 1.0.2 as well.

Up!

Updated patch from #47 for new release 3.0.12

t1mm1 → created an issue.

Got same issue for D core 10.2.4+.

Any updates?

Thanks @sandykadam!

Got same error, back to the version 1.1 is helped.

Any ETA for this fix? Any patch?
Thanks.

I did add 'remove' button. Will add patch after testing and code review on our project. Currently it was tested on D10 only.

Found one case on same structure for empty config when content is empty. Added to the patch as well. It makes fatal on new link creation from typical menu item form.

All previous patches were hidden as not actual.

updated
checked

updated
checked

Patch for 1.14@beta.

t1mm1 → created an issue.

updated

patch

t1mm1 → created an issue.

the patch for the check empty value

t1mm1 → created an issue.

Updated. 'form_node_form' check was changed to 'form_alter'.

Unmove from my account. I think it should be reviewed from module's owner.

Unmove from my account. I think it should be reviewed from module's owner.

Please, take a look for review.

Please, take a look for review.

Please, take a look for review.

The patch.

t1mm1 → created an issue.

The patch.

(D org comment process allow me add empty comment before, omg)

t1mm1 → created an issue.

I also added some checking for empty values. Via some processes it makes fatal as well.

The patch

The patch

The patch

Also, take a look - I use 'once' as it was added in the D10. It means that need update menu_tree.libraries.yml file as well..

As it on my local now.

menu-tree:
  version: 1.0
  js:
    js/tree.js: { }
  css:
    theme:
      css/tree.css: { }
  dependencies:
    - core/jquery
    - core/drupal
    - core/once

I did add version and dependicies.

Thanks.

t1mm1 → created an issue.

t1mm1 → created an issue.

t1mm1 → created an issue.

The patch hrlps to fix the issue.
Thanks.

The patch

t1mm1 → created an issue.

t1mm1 → created an issue.

t1mm1 → created an issue.

Reviewed and tested.

rjjakes → credited t1mm1 → .

Patch

t1mm1 → created an issue. See original summary → .

Hi,

I did update the patch for D10 moving (8.13.0). Did remove some mess from js - lines that marked as updated but in fact that wasnt updated.
+ added patch for php8 fix issues.

So, I wanna ask - can I help you with update module to D10 core vestion?
Maybe, ..make new fork...?
7 months no updates..

Lemme know if you need help for that.
Thanks.