Just adding ^11 to the info file does not make this module compatible with Drupal 11. The module depends on the core `Actions UI` module which is deprecated and removed from Drupal 11 code. So, this means that this module for its Drupal 11 version should be compatible with the contributed Actions UI → module instead. See the relevant issue: https://www.drupal.org/project/change_author_action/issues/3459371 🐛 Replaced Deprecated Actions Module Active
Moreover and generally speaking, commits and merge requests should be atomic and address a single task (feature, bug fix etc) at a time. Your patch and MR contains both a feature (the alleged 11 support), plus some code styling and beautification changes. It is highly confusing to see, understand and review what the actual feature code is. IMO, those should be two separate MRs, each one accurately describing the task.
I've tested patch #12 in Drupal 10.2.7 and it works. I confirm RTBC status.
This is my opinion/review on the available patches:
Patch
#13
🐛
After changing focal point, image doesn't change until you click preview
Needs review
, also contains a code style enhancement ([$x, $y] = explode(',', $focal_point);) which a) is already implemented in module's latest version (2.1.0) and b) is not related to this issue. Patch should be ignored, as patches should only address one issue at a time.
Patch #33 🐛 After changing focal point, image doesn't change until you click preview Needs review is the correct version of patch#13 (without the code enhancement), but it does not solve the problem (at least in my env: Focal point 2.1.0, Drupal 10.2.7).
Patch #20 🐛 After changing focal point, image doesn't change until you click preview Needs review solves the aforementioned problem. This is the one that should be accepted. @gwenweb I verify that only the updated image gets flushed/regenerated and not all images.
Patch #24 🐛 After changing focal point, image doesn't change until you click preview Needs review is practically the same code as in patch#20, only the paths to the module file are different. People complained that patch#20 could not be applied to their envs, hence the re-roll with different paths.
Patch #27 🐛 After changing focal point, image doesn't change until you click preview Needs review is the same code as in #20 and #24, plus it addresses the issue of updating webp generated images as well. Yes, it solves the problem with the webps, but it falsely assumes that there are webps to update. Image Optimize and ImageAPI Optimize WebP modules are not related to this module and they are definitely not prerequisites for it. So, any fix related to webps, should be addressed by those modules' end and not from this one. This patch should be ignored.
This issue is a duplicate of https://www.drupal.org/project/menu_breadcrumb/issues/3362822 🐛 Duplicate the current page of views Needs review