addMissingCurrentPage adds current page some times incorrectly

Open on Drupal.org →

Created on 14 September 2023, 10 months ago

Updated 5 October 2023, 9 months ago

Problem/Motivation

While using the module I noticed that on a certain page the breadcrumb was "Shop/Posters/Posters" but in other pages it was like it supposed to be for example "Shop/Fine Art". After some digging inside the code I noticed that on MenuBasedBreadcrumbBuilder::addMissingCurrentPage() (line 407) the $last_url->getRouteParameters() and $route_match->getRawParameters()->all() returned the same array but in different order. This was causing the equality check to return false and proceed to add the current url.

Steps to reproduce

Not sure why the 2 arrays had a different order.

Proposed resolution

Check the arrays equality in a way that does not care about the order.

🐛 Bug report

Status

Closed: duplicate

Version

1.16

Component

Code

Created by

🇬🇷Greece Christos Diamantis

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @Christos Diamantis
Comment 10 months ago →
🇬🇷Greece Christos Diamantis
Comment 10 months ago →
🇬🇷Greece Christos Diamantis
Comment 9 months ago →
annoul4
Hello,

Did you manage to figure out why the order is different? I have the same issue.
Comment 9 months ago →
annoul4
Answering my own question:
MenuBasedBreadcrumbBuilder.php, line 406 - last_url route parameters are sorted alphabetically (see MenuTreeStorage line 390)
Comment 9 months ago →
🇬🇷Greece akz
This issue is a duplicate of https://www.drupal.org/project/menu_breadcrumb/issues/3362822 🐛 Duplicate the current page of views Needs review
Status changed to Closed: duplicate 9 months ago7:37am 5 October 2023
Comment 9 months ago →
🇬🇷Greece akz

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024